rosdistro: ROS kinetic pcl dependency conflict

Hi guys,

There was a new release of libvtk6-dev on 2020-11-30 on ubuntu xenial, that conflicts with the osrf one, and in consequence with ros-kinetic-pcl-ros package.

The osrf release for vtk6 is 6.2.0+dfsg1-10build1+debian11.1+osrf1.

As the most updated" version now, is the ubuntu updates one we are not installing the osrf version.

Can we have an update on this lib?

Related pcl issue

Thanks!

About this issue

  • Original URL
  • State: closed
  • Created 6 years ago
  • Reactions: 9
  • Comments: 19 (15 by maintainers)

Commits related to this issue

Most upvoted comments

I just talked with @kyrofa and since the upstream libvtk and libpcl are both now consistent the simplest solution is to do the general rebuild of Kinetic to use the consistent libproj. Although it’s not an ABI break, the solution is similar, we will rebuild all packages in Kinetic depending on libvtk6 and anyone with compiled binary distributions will have to do the same. This will take some server time but will provide the simplest solution in the long run.

Process:

  1. rebuild all kinetic packages on top of the new libvtk6

    Dependencies of libvtk6-dev

    • ros-kinetic-pointcloud-tools (N/A pcl_ros upstream)

    Dependencies of libpcl-dev

    • ros-kinetic-thormang3-sensors (N/A pcl_conversions upstream)
    • ros-kinetic-rtt-pcl uxv8 uX32 uX64 uXhf
    • ros-kinetic-rtabmap uX32 uXv8 uXhf uX64
    • ros-kinetic-rc-cloud-accumulator (N/A pcl_ros upstream)
    • ros-kinetic-pcl-ros (N/A pcl_conversions upstream)
    • ros-kinetic-pcl-conversions uXv8 uXhf uX64 uX32
    • ros-kinetic-ira-laser-tools (N/A pcl_ros upstream)
    • ros-kinetic-ifm3d-core uX32 uX64 uXhf uXv8
    • ros-kinetic-cob-map-accessibility-analysis (N/A pcl_ros upstream)
    • ros-kinetic-cartographer-ros (N/A pcl_conversions upstream)
  1. validate the fix in shadow-fixed
  2. Sync and notify all users to do a dist-upgrade to make sure to get all the new binaries, and recommend all binary distributed content to be recompiled as well.

Selection listings:

root@63f5bbc412e4:/# apt-cache rdepends libpcl-dev
libpcl-dev
Reverse Depends:
  libpcl-conversions-dev
  ros-lunar-rtabmap
  ros-lunar-rc-cloud-accumulator
  ros-lunar-pcl-ros
  ros-lunar-pcl-conversions
  ros-lunar-navfn
  ros-lunar-ira-laser-tools
  ros-lunar-dwa-local-planner
  ros-lunar-costmap-2d
  ros-lunar-cartographer-ros
  ros-lunar-base-local-planner
  ros-kinetic-thormang3-sensors
  ros-kinetic-rtt-pcl
  ros-kinetic-rtabmap
  ros-kinetic-rc-cloud-accumulator
  ros-kinetic-pcl-ros
  ros-kinetic-pcl-conversions
  ros-kinetic-ira-laser-tools
  ros-kinetic-ifm3d-core
  ros-kinetic-cob-map-accessibility-analysis
  ros-kinetic-cartographer-ros
  ros-perception-dev
root@63f5bbc412e4:/# apt-cache rdepends libvtk6-dev
libvtk6-dev
Reverse Depends:
  libvtk6-java
  vtk6-examples
  vtk6-doc
  ros-kinetic-pointcloud-tools
  libvtk6-qt-dev
  libvtk6-qt-dev
  libvtk6-qt-dev
  libvtk6-java
  vtk6-examples
  vtk6-doc
  libvtk6-qt-dev
  libvtk6-qt-dev
  libvtk6-qt-dev
  libvtk6-qt-dev
  libpcl-dev
  vtk6-examples
  vtk6-doc
  science-viewing-dev
  libvtk6-qt-dev
  libvtk6-java
  libvtk6-qt-dev
  libpcl-dev

Yeah, to clarify, the state of Ubuntu before the bugfix was:

  • libvtk6 has a vendored copy of libproj that it used to use. When it was being used, it was called, sensibly, vtkproj4. However, the version in Xenial doesn’t use that vendored copy, and thus doesn’t build it, linking instead to the system libproj. As a result, it didn’t provide a library named vtkproj4
  • libvtk6, despite building against and requiring libproj, did not add it to its dependency list (bug 1)
  • libpcl-dev was built back when libvtk6 WAS using its vendored libproj, and thus had vtkproj4 written into its PCLConfig.cmake files (bug 2)

As a result, anyone using libvtk6 ended up with errors because they were using a library that required libproj to be installed, but it didn’t depend on it (bug 1). Also, anyone using cmake to link to pcl ended up with build errors because they were trying to link to a library that didn’t exist (bug 2). It was just all-around broken.

The fix that Open Robotics got into their Debian archive was to modify libvtk6 to start building and using its vendored libproj again, which made the libpcl in Xenial work because it could find that vtkproj4 library again. However, the vendored libproj is not ABI compatible with the system libproj, so that’s not something I could safely make happen in Xenial. I instead made libvtk6 properly depend upon libproj, and then rebuilt libpcl so it didn’t have a library that didn’t exist in its cmake config.

We have two options for now: new release on vtk6 and pcl on top of the new one, or rebuild all ros packages dependent on PCL and their dependencies.

That’s my thinking anyway, yes. Right now things like pcl_rosConfig.cmake and costmap_2dConfig.cmake contain vtkproj4. The possible fixes are:

  • Make vtkproj4 exist again (by continuing to carry the patch) and also carry a patch to libpcl to use the vendored libproj (watch your versions though, another fix is inbound)
  • Rebuild things to use the system libproj instead of the vendored libproj

What about just releasing a new vtk6, but leave pcl as it is, leaving vtk-vendored libproj dangling? Too fragile? This would allow to update the packages libraries as we go. Does it make sense?

No, I think that will break. It’s exactly the opposite situation of the breakage that was in Xenial before this happened:

  • libvtk will be using its vendored libproj
  • libpcl will be using the system libproj

I suspect that will be one big segfault for anyone trying to use libpcl.

As far as I understand it, it may not quite be the same. I believe you followed the Debian reversion back to the vtk-vendored libproj, right? We can’t do that in Ubuntu as it would have broken ABI, so I tried to fix it by instead pushing all the way through to using the system libproj by adding the dep and rebuilding libpcl to have the proper library in its cmake config files. In a way I kinda broke your ABI by… not breaking ABI 🤔 . And then the pcl rebuild is the cherry on top. More info here. @tfoote we can set up a time to chat tomorrow if you like.