rosdistro: Regression in rplidar_ros package.

Version 2.1.2 of rplidar_ros was merged recently (#37606). This release came from https://github.com/Slamtec/rplidar_ros/tree/ros2, while previous releases were from this fork https://github.com/allenh1/rplidar_ros. The new release has some breaking changes such as node name changes and missing features.

About this issue

  • Original URL
  • State: closed
  • Created 3 years ago
  • Comments: 17 (17 by maintainers)

Most upvoted comments

@deyouslamtec This looks like a regression as well as you’re taking over maintinership(from @allenh1 ) of the package w/o a notice to the ROS community in your PR (#37606 ) it would be much better to mention that instead of just considering it a point release.

@audrow I would suggest a rollback of this in the immediate term as it’s only in testing right now and significantly breaks active humble users including the TurtleBot 4 community. https://github.com/turtlebot/turtlebot4/issues/194 Then a migration plan can be determined for how to do this update without breaking existing users.

@allenh1 I agree. I have renamed my ros2 branch to ros2-devel,you can push your ros2 branch to my repository now.

@deyouslamtec I will just request that if the code base is changing to the Slamtec github, try to merge in some of the new features that are available in https://github.com/allenh1/rplidar_ros beforehand.

In an effort to preserve existing code, maybe the ownership of my repository should simply be transferred to @deyouslamtec, and they can operate on that codebase.

I think we could make the migration a bit less painful for everyone by just having one repo instead of two.

@audrow I would suggest a rollback of this in the immediate term as it’s only in testing right now and significantly breaks active humble users including the TurtleBot 4 community. turtlebot/turtlebot4#194

@tfoote, I merged in your revert. Thanks for moving fast on this.

I’m a little confused… Has this been released as part of a sync? If so, will installed binaries with this version update to the new one, or should I release a new version in the interim?

@allenh1, it doesn’t look like this was included in the last sync. The last version synced was 2.1.0. Otherwise, I’d have to make another sync. https://repo.ros2.org/status_page/ros_humble_default.html?q=rplidar_ros