romcal: bug: duplicate celebrations
I’ve just found out that the Sts Cyril and Methodius have two feast days in the output of romcal. One is according to General Roman Calendar on 14th February (which is never celebrated in Slovakia) and the other on 5th July (which is always celebrated in Slovakia, as it is a feast and public holiday in Slovakia).
Here are the lines I found:
$ cat calendars/slovakia.js | grep -nA4 -B2 Cyril
14- var dates = [
15- {
16: "key": "saintsCyrilMonkAndMethodiusBishop",
17- "type": Types[4],
18- "moment": moment.utc({ year: arguments[0], month: 1, day: 14 }),
19- "data": {
20- "meta": {
--
105- },
106- {
107: "key": "saintsCyrilAndMethodiusSlavicMissionaries",
108- "type": Types[0],
109- "moment": moment.utc({ year: arguments[0], month: 6, day: 5 }),
110- "data": {}
111- },
I suggest to remove the first one from the Slovakian calendar (calendar/slovakia.js).
About this issue
- Original URL
- State: closed
- Created 9 years ago
- Reactions: 1
- Comments: 104 (99 by maintainers)
Commits related to this issue
- (fix) partial fixes for issue #10 — committed to romcal/romcal by pejulian 9 years ago
- issue #10: further removal of duplicates discovered by tukusejssirs — committed to romcal/romcal by pejulian 9 years ago
- issue #10: further removal of duplicates discovered by tukusejssirs — committed to romcal/romcal by pejulian 9 years ago
- issue #10: further removal of key duplicates discovered by tukusejssirs — committed to romcal/romcal by pejulian 9 years ago
- issue #10: Fixes for duplicate keys — committed to romcal/romcal by pejulian 9 years ago
- (fix) partial fixes for issue #10 — committed to emagnier/romcal by pejulian 9 years ago
- issue #10: further removal of key duplicates discovered by tukusejssirs — committed to emagnier/romcal by pejulian 9 years ago
- issue #10: further removal of duplicates discovered by tukusejssirs — committed to emagnier/romcal by pejulian 9 years ago
- issue #10: further removal of duplicates discovered by tukusejssirs — committed to emagnier/romcal by pejulian 9 years ago
- (fix) partial fixes for issue #10 — committed to emagnier/romcal by pejulian 9 years ago
- issue #10: further removal of key duplicates discovered by tukusejssirs — committed to emagnier/romcal by pejulian 9 years ago
- issue #10: further removal of duplicates discovered by tukusejssirs — committed to emagnier/romcal by pejulian 9 years ago
- issue #10: further removal of duplicates discovered by tukusejssirs — committed to emagnier/romcal by pejulian 9 years ago
- (fix) partial fixes for issue #10 — committed to emagnier/romcal by pejulian 9 years ago
- issue #10: further removal of key duplicates discovered by tukusejssirs — committed to emagnier/romcal by pejulian 9 years ago
- issue #10: further removal of duplicates discovered by tukusejssirs — committed to emagnier/romcal by pejulian 9 years ago
- issue #10: further removal of duplicates discovered by tukusejssirs — committed to emagnier/romcal by pejulian 9 years ago
- (fix) partial fixes for issue #10 — committed to emagnier/romcal by pejulian 9 years ago
- issue #10: further removal of key duplicates discovered by tukusejssirs — committed to emagnier/romcal by pejulian 9 years ago
- issue #10: further removal of duplicates discovered by tukusejssirs — committed to emagnier/romcal by pejulian 9 years ago
Found another (possible) duplicates:
$ cat en.mjs | grep -in anselm 111: “saintAnselmOfCanterburyBishopAndDoctorOfTheChurch”: “Saint Anselm of Canterbury, Bishop and Doctor of the Church”, 392: “saintAnselmOfCanterburyBishopAndDoctorOfTheChurch”: “Saint Anselm of Canterbury, Bishop and Doctor of the Church”,
$ cat en.mjs | grep -in birthOfTheBlessedVirginMary 190: “birthOfTheBlessedVirginMary”: “Birth of the Blessed Virgin Mary”, 608: “birthOfTheBlessedVirginMary”: “Birth of the Blessed Virgin Mary”,
$ cat en.mjs | grep -in blessedBoleslawaMariaLamentVirgin 651: “blessedBoleslawaMariaLamentVirginsaintAngelaMericiVirgin”: “Blessed Boleslawa Maria Lament, Virgin/Saint Angela Merici, Virgin”, 723: “blessedBoleslawaMariaLamentVirgin”: “Blessed Boleslawa Maria Lament, Virgin”,
$ cat en.mjs | grep -in blessedInacioDeAzevedoPriestAnd 327: “blessedInacioDeAzevedoPriestAndMartyr”: “Blessed Inacio de Azevedo, Priest and Martyr”, 706: “blessedInacioDeAzevedoPriestAndCompanionsMartyrs”: “Blessed Inacio de Azevedo, Priest, and Companions, Martyrs”,
$ cat en.mjs | grep -in blessedLauraVicuna 256: “blessedLauraVicuna”: “Blessed Laura Vicuna”, 353: “blessedLauraVicunaVirgin”: “Blessed Laura Vicuna, Virgin”,
These are all I found in
en.mjs. First, I sorted the file alphabetically, so there should be no more found in this file.$ grep -in saintTeresaOfJesusVirginAndDoctorOfTheChurch enUs.mjs 208: “saintTeresaOfJesusVirginAndDoctorOfTheChurch”: “Saint Teresa of Jesus, Virgin and Doctor”, 719: “saintTeresaOfJesusVirginAndDoctorOfTheChurch”: “Saint Teresa of Jesus, Virgin and Doctor of The Church”,
Also, there is a duplicate in
unitedStates.mjs:$ grep -in saintJohnOfKantyPriest enUs.mjs 250: “saintJohnOfKantyPriest”: “Saint John of Kanty, Priest”, 647: “saintJohnOfKantyPriest”: “Saint John of Kanty, Priest”,
$ grep -in saintMariaGorettiVirginAndMartyr enUs.mjs 150: “saintMariaGorettiVirginAndMartyr”: “Saint Maria Goretti, Virgin and Martyr”, 625: “saintMariaGorettiVirginAndMartyr”: “Saint Maria Goretti, Virgin and Martyr”,
$ grep -in saintStanislausBishopAndMartyr enUs.mjs 109: “saintStanislausBishopAndMartyr”: “Saint Stanislaus, Bishop and Martyr”, 615: “saintStanislausBishopAndMartyr”: “Saint Stanislaus, Bishop and Martyr”,
Probably by mistake (or ‘mis-stroke’), you duplicated the
ourLadyOfLujanPatronessOfArgentina:$ grep -in saintCasimir enUs.mjs 98: “saintCasimir”: “Saint Casimir”, 569: “saintCasimir”: “Saint Casimir”,
$ grep -in saintFrancisXavierPriest enUs.mjs 240: “saintFrancisXavierPriest”: “Saint Francis Xavier, Priest”, 503: “saintFrancisXavierPriest”: “Saint Francis Xavier, Priest”,
$ grep -in saintThomasTheApostle enUs.mjs 147: “saintThomasTheApostle”: “Saint Thomas the Apostle”, 501: “saintThomasTheApostle”: “Saint Thomas The Apostle”,
$ grep -in saintStephenOfHungary enUs.mjs 179: “saintStephenOfHungary”: “Saint Stephen of Hungary”, 488: “saintStephenOfHungary”: “Saint Stephen of Hungary”,
$ grep -in presentationOfTheBlessedVirginMary enUs.mjs 234: “presentationOfTheBlessedVirginMary”: “Presentation of the Blessed Virgin Mary”, 474: “presentationOfTheBlessedVirginMary”: “Presentation of The Blessed Virgin Mary”,
$ grep -in ourLadyOfFatima enUs.mjs 122: “ourLadyOfFatima”: “Our Lady of Fatima”, 467: “ourLadyOfFatima”: “Our Lady of Fatima”,
$ grep -in saintCyrilOfJerusalemBishopAndDoctor enUs.mjs 103: “saintCyrilOfJerusalemBishopAndDoctor”: “Saint Cyril of Jerusalem, Bishop and Doctor”, 465: “saintCyrilOfJerusalemBishopAndDoctor”: “Saint Cyril of Jerusalem, Bishop and Doctor”,
$ grep -in visitationOfTheBlessedVirginMary enUs.mjs 132: “visitationOfTheBlessedVirginMary”: “Visitation of the Blessed Virgin Mary”, 436: “visitationOfTheBlessedVirginMary”: “Visitation of The Blessed Virgin Mary”,
$ grep -in saintPeterCanisiusPriestAndDoctor enUs.mjs 249: “saintPeterCanisiusPriestAndDoctor”: “Saint Peter Canisius, Priest and Doctor”, 430: “saintPeterCanisiusPriestAndDoctor”: “Saint Peter Canisius, Priest and Doctor”,
$ grep -in saintHenryBishopAndMartyr enUs.mjs 153: “saintHenryBishopAndMartyr”: “Saint Henry, Bishop and Martyr”, 399: “saintHenryBishopAndMartyr”: “Saint Henry, Bishop and Martyr”,
$ grep -in saintScholasticaVirgin enUs.mjs 91: “saintScholasticaVirgin”: “Saint Scholastica, Virgin”, 297: “saintScholasticaVirgin”: “Saint Scholastica, Virgin”,
$ grep -in saintCatherineOfSienaVirginAndDoctorOfTheChurch enUs.mjs 116: “saintCatherineOfSienaVirginAndDoctorOfTheChurch”: “Saint Catherine of Siena, Virgin and Doctor of The Church, Patron of Europe”, 300: “saintCatherineOfSienaVirginAndDoctorOfTheChurch”: “Saint Catherine of Siena, Virgin and Doctor of The Church, Patron of Europe”,
$ grep -in saintAnthonyMaryClaretBishop enUs.mjs 219: “saintAnthonyMaryClaretBishop”: “Saint Anthony Mary Claret, Bishop”, 293: “saintAnthonyMaryClaretBishop”: “Saint Anthony Mary Claret, Bishop”,
$ grep -in saintMartinDePorresReligious enUs.mjs 222: “saintMartinDePorresReligious”: “Saint Martin de Porres, Religious”, 294: “saintMartinDePorresReligious”: “Saint Martin de Porres, Religious”,
Duplicates and joined feasts:
$ grep -in saintCamillusDeLellisPriest enUs.mjs 153: “saintCamillusDeLellisPriest”: “Saint Camillus de Lellis, Priest”, 287: “saintCamillusDeLellisPriest”: “Saint Camillus de Lellis, Priest”, 347: “saintCamillusDeLellisPriestOrSaintHenry”: “Saint Camillus de Lellis, Priest, Or Saint Henry”,
$ grep -in saintPeterClaverPriest enUs.mjs 191: “saintPeterClaverPriest”: “Saint Peter Claver, Priest”, 288: “saintPeterClaverPriest”: “Saint Peter Claver, Priest”,
$ grep -in lambert enUs.mjs 281: “saintLambertBishopAndMartyr”: “Saint Lambert, Bishop and Martyr”, 460: “saintLambertOfMaastrichtBishopAndMartyr”: “Saint Lambert of Maastricht, Bishop and Martyr”,
$ cat enUs.mjs | grep -in damien 278: “saintFatherDamienMissionary”: “Saint Father Damien, Missionary”, 750: “saintDamienDeVeusterPriest”: “Saint Damien de Veuster, Priest”,
Another possible duplicate:
$ cat …/locales/en.mjs | grep -n saintPeterChanelPriestAndMartyr 115: “saintPeterChanelPriestAndMartyrSaintLouisGrignonDeMontfortPriest”: “Saint Peter Chanel, Priest and Martyr/Saint Louis Grignon de Montfort, Priest”, 270: “saintPeterChanelPriestAndMartyr”: “Saint Peter Chanel, Priest and Martyr”,
$ cat en.mjs | grep -in ourLadyOfGuadalupe 244: “ourLadyOfGuadalupe”: “Our Lady of Guadalupe”, 274: “ourLadyOfGuadalupe”: “Our Lady of Guadalupe”,
$ cat en.mjs | grep -in saintPatrickBishop 102: “saintPatrickBishop”: “Saint Patrick, Bishop”, 277: “saintPatrickBishop”: “Saint Patrick, Bishop”,
$ cat en.mjs | grep -in ourLadyOfMountCarmel 155: “ourLadyOfMountCarmel”: “Our Lady of Mount Carmel”, 263: “ourLadyOfMountCarmel”: “Our Lady of Mount Carmel”, 357: “ourLadyOfMountCarmelMotherAndQueenOfChile”: “Our Lady of Mount Carmel, Mother and Queen of Chile”,
$ cat en.mjs | grep -in saintRoseOfLima 183: “saintRoseOfLimaVirgin”: “Saint Rose of Lima, Virgin”, 268: “saintRoseOfLima”: “Saint Rose of Lima”, 296: “saintRoseOfLimaVirgin”: “Saint Rose of Lima, Virgin”,
$ cat en.mjs | grep -in saintsRoqueGonzalezAlf 272: “saintsRoqueGonzalezAlfonsoRodriguezAndJuanDelCastilloPriestsAndMartyrs”: “Saints Roque Gonzalez, Alfonso Rodriguez, and Juan del Castillo, Priests and Martyrs”, 304: “saintsRoqueGonzalezAlfonsoRodriguezOlmedoAndJuanDelCastilloPriestsAndMartyrs”: “Saints Roque Gonzalez, Alfonso Rodriguez Olmedo, and Juan del Castillo, Priests and Martyrs”,
$ cat en.mjs | grep -in saintElizabethOfHungary 230: “saintElizabethOfHungaryReligious”: “Saint Elizabeth of Hungary, Religious”, 273: “saintElizabethOfHungary”: “Saint Elizabeth of Hungary”, 418: “saintHildaAbbessOrSaintHughOfLincolnBishopOrSaintElizabethOfHungary”: “Saint Hilda, Abbess Or Saint Hugh of Lincoln, Bishop Or Saint Elizabeth of Hungary”, 482: “saintElizabethOfHungaryReligious”: “Saint Elizabeth of Hungary, Religious”,
$ cat en.mjs | grep -in saintsAugustineZhaoRongPriestAndCompanionsMartyrs 150: “saintsAugustineZhaoRongPriestAndCompanionsMartyrs”: “Saints Augustine Zhao Rong, Priest, and Companions, Martyrs”, 262: “saintsAugustineZhaoRongPriestAndCompanionsMartyrs”: “Saints Augustine Zhao Rong, Priest, and Companions, Martyrs”,
$ cat en.mjs | grep -in isidoreof 106: “saintIsidoreOfSevilleBishopAndDoctorOfTheChurch”: “Saint Isidore of Seville, Bishop and Doctor of the Church”, 737: “saintIsidoreOfSevilleBishopAndDoctorOfTheChurch”: “Saint Isidore of Seville, Bishop and Doctor of The Church”,
$ cat en.mjs | grep -in saintTuribiusOfMogrovejoBishop 104: “saintTuribiusOfMogrovejoBishop”: “Saint Turibius of Mogrovejo, Bishop”, 257: “saintTuribiusOfMogrovejoBishop”: “Saint Turibius of Mogrovejo, Bishop”,
$ cat en.mjs | grep -in arbel 160: “saintSharbelMakhlufPriestAndHermit”: “Saint Sharbel Makhlūf, Priest and Hermit”, 264: “saintSharbelMakhlufPriestAndHermit”: “Saint Sharbel Makhlūf, Priest and Hermit”, 591: “saintCharbelPriest”: “Saint Charbel, Priest”,
$ cat en.mjs | grep -in “barbara\|damasc” 239: “saintJohnDamascenePriestAndDoctor”: “Saint John Damascene, Priest and Doctor”, 486: “saintBarbaraVirginAndMartyrOrBlessedAdolphKolpingPriest”: “Saint Barbara, Virgin and Martyr Or Blessed Adolph Kolping, Priest”, 499: “saintJohnDamasceneOrSaintBarbara”: “Saint John Damascene Or Saint Barbara”, 589: “saintBarbaraVirginAndMartyr”: “Saint Barbara, Virgin and Martyr”,
Note: Probably
saintBarbaraVirginAndMartyrOrBlessedAdolphKolpingPriestkey is not a duplicate, but as I am unsure, I kept it in the output.$ cat en.mjs | grep -in magall 126: “saintChristopherMagallanesAndCompanionsMartyrs”: “Saint Christopher Magallanes and Companions, Martyrs”, 619: “saintCristobalMagallanesAndCompanionsMartyrs”: “Saint Cristobal Magallanes and Companions, Martyrs”,
Possible duplicate:
$ cat en.mjs | grep -n GallAb 479: “saintGallAbbot”: “Saint Gall, Abbot”, 580: “saintGallAbbotAndMissionary”: “Saint Gall, Abbot and Missionary”,
$ cat en.mjs | grep -in birthOfTheBlessedVirginMary 190: “birthOfTheBlessedVirginMary”: “Birth of the Blessed Virgin Mary”, 608: “birthOfTheBlessedVirginMary”: “Birth of the Blessed Virgin Mary”,
cat en.mjs | grep -in saintApollinaris 156: “saintApollinaris”: “Saint Apollinaris”, 669: “saintApollinaris”: “Saint Apollinaris”,
$ cat en.mjs | grep -in benedictofnu 151: “saintBenedictOfNursiaAbbot”: “Saint Benedict of Nursia, Abbot, Patron of Europe”, 314: “saintBenedictOfNursiaAbbot”: “Saint Benedict of Nursia, Abbot, Patron of Europe”,
In (English/General) calendar, on 5th July, Saint Anthony Zaccaria, Priest is celebrated, but in Slovakia it is moved to 7th July.
$ cat en.mjs | grep -in alexandr 143: “saintCyrilOfAlexandriaBishopAndDoctor”: “Saint Cyril of Alexandria, Bishop and Doctor”, 236: “saintCatherineOfAlexandriaVirginAndMartyr”: “Saint Catherine of Alexandria, Virgin and Martyr”, 497: “saintCyrilOfAlexandriaBishopAndDoctor”: “Saint Cyril of Alexandria, Bishop and Doctor”, 616: “saintCatherineOfAlexandriaVirginAndMartyr”: “Saint Catherine of Alexandria, Virgin and Martyr”,
Still, I found another which I somehow missed:
$ cat en.mjs | grep -in matthi 123: “saintMatthiasTheApostle”: “Saint Matthias the Apostle”, 450: “saintMatthiasApostle”: “Saint Matthias, Apostle”,
As for the translation/l10n/i18n, is there any particular need of the blank line at the end of the locale files?
Edit: It is probably just my editor. 😃
Excerpt from
Readme.mdfromromcal-es6branch:‘For the national calendars of the Czech Republic and Slovakia (country: czechRepublic and slovakia), an additional flag can be passed:
We never have a fwast nor solemnity on 14th Feb. There might be a mere votive Holy Mass, but on 5th July there is always a Solemnity. 😃
So there might be a flag like this, but only to add votive Holy Mass on 14th Feb … but still it might be included as a ‘standard’ votive Holy Mass and that would eliminate the need of the flag. 😃