romcal: Error with "psalterWeek": "WEEK_2" when its WEEK_1 and

Error from january 2-4, this error: "psalterWeek": "WEEK_2" and it should be "psalterWeek": "WEEK_1"

And same for this current week (6-11): "psalterWeek": "WEEK_3" and should be "psalterWeek": "WEEK_2"

About this issue

  • Original URL
  • State: closed
  • Created 2 years ago
  • Comments: 33 (31 by maintainers)

Commits related to this issue

Most upvoted comments

indeed it should. checking the epiphany week calculation…

@miguelms95 and @Fernando-Perles, we have fixed this issue in #744 and released a new romcal version (v3.0.0-dev.94).

Thanks! @tukusejssirs @TobiTenno

@miguelms95 and @Fernando-Perles, we have fixed this issue in #744 and released a new romcal version (v3.0.0-dev.94).

i’m working on an efficient cacheable implementation of the test you provided so that we have a good way to verify before/after. i think that makes sense.

As I mentioned before, I think we need to specify certain cycles to start their psalter rotations over on a given week or feast.

In the psalter (and intimated by the GILH), the octave of christmas is outside the psalter schedule, so i would propose that the season of christmas octave be separated from the christmas season as that seems to be when the psalter resets.

Specifically, making the psalter restart after the octave of christmas would allow the new season to reset correctly, as well as forcing the octave of christmas to be it’s own “1 week psalter”.

sharing here for future reference, we need to update this. Summarizing, we use the week of the season to determine psalter week. This should just require updating the above to account for taking off an extra week in the Christmas Season.

Relating to what @Fernando-Perles mentioned, January 13th is resetting correctly, since it starts OT; so that’s kind of where this all corrects itself, as the Church resets the psalter cycle at the start of each season.

As an additional point, JANUARY, 12th, baptism_of_the_lord, should be WEEK_3, not week_4, eventhough it is an isolated day as the following Monday ordinary time starts.