refined-github: PR diff indentation broken

Hi! I’ve ran into a bug where Refined GitHub causes a problem with the indention in pull request diffs. I tried to look through the recent changelog as the issue happened, for me, between last Friday and this Monday. I restarted my computer and thus my browser for the first time in ~7 days this weekend as well. So I assume an update to Refined GitHub might have been applied.

This is on a private GitHub Enterprise 2.16.9 deployment. The URL to the page is something like (private components redacted): https://<host>/<org>/<repo>/pull/128/files

With Refined GitHub I see:

When disabling the extension the text is indented correctly: Vanilla GitHub

It seems like it might be related to some text-indent changes? E.g. https://github.com/sindresorhus/refined-github/pull/2088 . However tried disabling indented-code-wrapping as suggested in that issue but the indentation was still broken.

About this issue

Original URL
State: closed
Created 5 years ago
Reactions: 3
Comments: 15 (8 by maintainers)

Most upvoted comments

The content is double-indented in the second screenshot. I’m seeing the same thing in our GitHub instance over at Stack as well.

NickCraver on Jun 25, 2019

Ah that looks like it. I can see the fix is working when adding display: block to the span.blob-code-inner elements. However if I add the rgh-code-wrapping-enabled class to the table, I don’t get the changes.

I am also seeing other missing css (I have the exact issue described in https://github.com/sindresorhus/refined-github/issues/2174 and I’m just now noticing that I don’t have other adjustments like the left aligned labels in the pr view anymore).

So looks like this is just GHE missing css.

tknickman on Jun 25, 2019

Hitting same issue on Github Enterprise, not seeing it on github.com, updating to 19.6.24 fixes it for me. I had to manually uninstall and reinstall to pick up the update (although I assume if I had waited it would have updated in the background).

EDIT: Scratch that, the UI issue is now showing again. No idea why it went away temporarily after I uninstalled and reinstalled the extension.

gibfahn on Jun 24, 2019

I’ve got a weird feeling in my gut now.

@rastersize can you confirm that this happens even when you’ve disabled this feature. And I also want you to make sure that the feature is actually being disabled (because of #2170).

Finally if you don’t mind, can you copy-paste the code content here (redacted of course), need to see what the indentation is.

notlmn on Jun 24, 2019