refined-github: PR diff layout broken
Description
All diff views are broken on GitHub since at least this morning. I saw it working the last time on Friday before the weekend.
I don’t know if it’s related but the following error is thrown in the console.
Uncaught TypeError: Cannot read properties of undefined (reading 'cloneNode')
at refined-github.js:9671:37
at observe.signal.signal (refined-github.js:9680:12)
at window.addEventListener.signal.signal (refined-github.js:5083:9)
The feature causing this issue seems to be no-unnecessary-split-diff-view.
How to replicate the issue
Just open any page that shows a diff on GitHub, commit, PR etc Here is an example https://github.com/levrik/mdi-react/commit/ea0580f795f027cb77a0bb8b45db95ed5191738a
Extension version
22.10.10
Browser(s) used
Microsoft Edge 106.0.1370.37
About this issue
- Original URL
- State: closed
- Created 2 years ago
- Reactions: 9
- Comments: 15 (6 by maintainers)
Commits related to this issue
- Hotfix `no-unnecessary-split-diff-view` https://github.com/refined-github/refined-github/issues/6061 — committed to refined-github/yolo by fregante 2 years ago
- 22.10.10 `no-unnecessary-split-diff-view` https://github.com/refined-github/refined-github/issues/6061 — committed to refined-github/yolo by fregante 2 years ago
The feature has been temporarily disabled via hotfix
22.10.11 out soon
Just wanted to shout out how great it is that the feature can be disabled without have to wait for another release or install a pre-release. 👍🏼 ❤️
You mean Chrome Web Store?
I sent an actual CSS hotfix so the feature continues working and the bug is fixed.
I suppose tomorrow I will release 20.10.11 with a proper fix in #6063
@ovflowd are you using the version from the store? I’m using the same browser for testing and hotfixes work
@fregante I still see this issue happening 😅 (Example on screenshot below)
Is there any action needed from the user side? (Already using latest version of the extension)