refined-github: Not working on GitHub Enterprise on Firefox
Hello,
I came across this add-on while looking for a way to expand all in a PR. I installed the Firefox Plugin (on Firefox Quantum 57.0.1 (64-bit) on macOS Sierra 10.12.6).
I then went to my GitHub site and right clicked the add-on icon in the toolbar and selected “Enable Refined GitHub on this domain” and then got a Console error:
Content Security Policy: Directive ‘frame-src’ has been deprecated. Please use directive ‘child-src’ instead. (unknown)
Content Security Policy: The page’s settings blocked the loading of a resource at self (“style-src https://addons-amo.cdn.mozilla.net 'sha256-DiZjxuHvKi7pvUQCxCVyk1kAFJEUWe+jf6HWMI5agj4='”). Source: height:0;. refined-github-
Content Security Policy: The page’s settings blocked the loading of a resource at self (“style-src https://addons-amo.cdn.mozilla.net 'sha256-DiZjxuHvKi7pvUQCxCVyk1kAFJEUWe+jf6HWMI5agj4='”). refined-github-
Use of getAttributeNode() is deprecated. Use getAttribute() instead. amo-f054c6afa6f806bf24d3.js:1:758581
Content Security Policy: The page’s settings blocked the loading of a resource at self (“style-src https://addons-amo.cdn.mozilla.net 'sha256-DiZjxuHvKi7pvUQCxCVyk1kAFJEUWe+jf6HWMI5agj4='”). refined-github-:1
Use of getAttributeNode() is deprecated. Use getAttribute() instead. amo-f054c6afa6f806bf24d3.js:1:758581
1512639719416 addons.webextension.<unknown> WARN Loading extension 'null': Reading manifest: Error processing background.persistent: Event pages are not currently supported. This will run as a persistent background page.
1512639719435 addons.xpi WARN Please specify whether you want browser_style or not in your options_ui options.
Unparseable host permission moz-extension://98fb463d-81f7-4b41-a35b-70f593e91649/* Extension.jsm:840
Use of getAttributeNode() is deprecated. Use getAttribute() instead. amo-f054c6afa6f806bf24d3.js:1:758581
1512639720452 addons.webextension.{a4c4eda4-fb84-4a84-b4a1-f7c1cbf2a1ad} WARN Loading extension '{a4c4eda4-fb84-4a84-b4a1-f7c1cbf2a1ad}': Reading manifest: Error processing background.persistent: Event pages are not currently supported. This will run as a persistent background page.
Use of getAttributeNode() is deprecated. Use getAttribute() instead. amo-f054c6afa6f806bf24d3.js:1:758581
Existing options: Object { hideStarsOwnRepos: true } background.js:43:5
Running 1 migrations background.js:43:80
win.PopupNotifications is undefined ExtensionsUI.jsm:343
Error: An unexpected error occurred background.js:159:35
alert() is not supported in background windows; please use console.log instead. ext-c-toolkit.js:25:7
Error: An unexpected error occurred ext-c-toolkit.js:30:5
file:///Users/danicast/Library/Application%20Support/Firefox/Profiles/rpssnhlh.default/lwtheme/lightweighttheme-header-1920x1200?64912;0
OpenGL compositor Initialized Succesfully.
Version: 2.1 INTEL-10.25.17
Vendor: Intel Inc.
Renderer: Intel Iris Pro OpenGL Engine
FBO Texture Target: TEXTURE_2D
GET
XHR
https://aus5.mozilla.org/update/3/GMP/57.0.1/20171128222554/Darwin_x86_64-gcc3/en-US/release/Darwin%2016.7.0/default/default/update.xml
[HTTP/1.1 200 OK 1249ms]
POST
http://ocsp.digicert.com/
[HTTP/1.1 200 OK 44ms]
file:///Users/danicast/Library/Application%20Support/Firefox/Profiles/rpssnhlh.default/lwtheme/lightweighttheme-header-1920x1200?64912;0
file:///Users/danicast/Library/Application%20Support/Firefox/Profiles/rpssnhlh.default/lwtheme/lightweighttheme-header-1920x1200?64912;0
file:///Users/danicast/Library/Application%20Support/Firefox/Profiles/rpssnhlh.default/lwtheme/lightweighttheme-header-1920x1200?64912;0
file:///Users/danicast/Library/Application%20Support/Firefox/Profiles/rpssnhlh.default/lwtheme/lightweighttheme-header-1920x1200?64912;0
file:///Users/danicast/Library/Application%20Support/Firefox/Profiles/rpssnhlh.default/lwtheme/lightweighttheme-header-1920x1200?64912;0
Set option hideStarsOwnRepos to true options.js:75:25
file:///Users/danicast/Library/Application%20Support/Firefox/Profiles/rpssnhlh.default/lwtheme/lightweighttheme-header-1920x1200?64912;0
file:///Users/danicast/Library/Application%20Support/Firefox/Profiles/rpssnhlh.default/lwtheme/lightweighttheme-header-1920x1200?64912;0
POST
http://ocsp.godaddy.com/
[HTTP/1.1 200 OK 204ms]
file:///Users/danicast/Library/Application%20Support/Firefox/Profiles/rpssnhlh.default/lwtheme/lightweighttheme-header-1920x1200?64912;0
OpenGL compositor Initialized Succesfully.
Version: 2.1 INTEL-10.25.17
Vendor: Intel Inc.
Renderer: Intel Iris Pro OpenGL Engine
FBO Texture Target: TEXTURE_2D
Is this a known issue?
Thanks!
About this issue
- Original URL
- State: closed
- Created 7 years ago
- Reactions: 2
- Comments: 23 (14 by maintainers)
Update these lines in
manifest.json:https://github.com/sindresorhus/refined-github/blob/87b2f4fa2bdd89a48f3137692e1f082b106ccdd9/source/manifest.json#L46-L49
Ergh that should probably be fixed in the code. PR welcome
This is working fine for me in the firefox after new update version 61.0.1 .
The underlying bug seems to have been fixed. This should work in Firefox 61.
https://bugzilla.mozilla.org/show_bug.cgi?id=1382953#c20
I thought a xpi is just a zip with a different file extension? http://kb.mozillazine.org/Editing_an_add-on_to_change_its_compatibility https://www.techgainer.com/view-source-code-firefox-addon/
Sadly, Firefox doesn’t fully support permissions request, see https://bugzilla.mozilla.org/show_bug.cgi?id=1382953
More details https://github.com/sindresorhus/refined-github/pull/819#issuecomment-344918525