refined-github: `fork-source-link-same-view`: The `forked from` link will be broken if the case doesn't match

If you set your personal token and visit https://github.com/johntitor/rust-forge (note that the capitalization!), the forked from link will be broken.

The link will be:

The link causes 404 instead of moving to parent repo (e.g.: https://github.com/rust-lang/rust-forge/undefined/master). But if you don’t set the token or visit with the correct capitalization, the issue doesn’t happen.

Steps to reproduce

Set your personal token.
Find any fork repo that username has an upper case.
Visit there ignoring capitalization.

Expected behavior

The link should be such as https://github.com/owner/repo

Actual behavior

It points to https://github.com/owner/repo/undefined/master

Environment

Browser: Firefox 78.0.2
Extension version: 20.7.19
OS: Windows 10

About this issue

Original URL
State: closed
Created 4 years ago
Comments: 24 (19 by maintainers)

Most upvoted comments

We don’t have special logic for that button

We kind of have logic, but only if you’re in a file or folder. Following these steps doesn’t trigger that logic however:

Steps to reproduce

Visit a repo that you have fork repo.

Click the shortcut and go to (your) fork repo.

See forked from owner/repo link.

fregante on Jul 23, 2020

how did you get it to error? What link?

https://github.com/johntitor/rust-forge

👆 this is why we ask for the exact link when opening an issue.

fregante on Jul 23, 2020

its isRepoRoot failing

https://github.com/sindresorhus/refined-github/blob/fa73096928e267ec165452557d25a8226cc32d09/source/features/fork-source-link-same-view.tsx#L32-L35

yakov116 on Jul 23, 2020

how did you get it to error? What link?

https://github.com/johntitor/rust-forge

kidonng on Jul 23, 2020

it’s extension issue?

We know that it’s caused by Refined GitHub, but it’s not due to forked-to (the fork button) but fork-source-link-same-view

kidonng on Jul 23, 2020

note that the capitalization, it should be johntitor, not JohnTitor

Confirmed

kidonng on Jul 23, 2020

Nah, this issue occurs only when you go to the repo using the shortcut link.

We don’t have special logic for that button, it’s just a normal link. It should make no difference if you directly visit https://github.com/JohnTitor/rust-forge

kidonng on Jul 23, 2020

Can you give us a direct link?

yakov116 on Jul 23, 2020