fastlane: [Regression] Google Api Error: apkNotificationMessageKeyUpgradeVersionConflict leaves hanging edit for subsequent runs

New Issue Checklist

Issue Description

Running fastlane supply after a failed run due to trying to upload a new APK with an already taken version code will fail subsequent runs because an Edit is already in progress.

Command executed

Portion of fastlane job run over multiple iterations

    upload_to_play_store(
      package_name: package_to_upload, 
      track: internal,
      metadata_path: path_to_metadata,
      apk: apk_path,
      skip_upload_aab: true,
      skip_upload_images: false,
      skip_upload_screenshots: false,
      validate_only: true)
Steps to Reproduce
1.  With an existing Google Play app entry and uploaded APK, run the above command, providing an APK with the same version code as what's already in Google Play.
2. Observe the following Google API Error:
```[!] Google Api Error: apkNotificationMessageKeyUpgradeVersionConflict: APK specifies a version code that has already been used. - APK specifies a version code that has already been used.```
3. Increment the version code of the APK to something not already taken
4. Run the same command with the new APK and observe the following error, trigger on [this line](https://github.com/fastlane/fastlane/blob/master/supply/lib/supply/client.rb#L136)
```[!] You currently have an active edit```

Possible fix

Abort the pending edit left over by the run that threw the Google API Error. Calling this in the right places.

Last working version tested with: 2.132.0

Environment

### Stack
Key Value
OS 10.15.1
Ruby 2.6.1
Bundler? true
Git git version 2.21.0 (Apple Git-122.2)
Installation Source ~/.rbenv/versions/2.6.1/bin/fastlane
Host Mac OS X 10.15.1 (19B88)
Ruby Lib Dir ~/.rbenv/versions/2.6.1/lib
OpenSSL Version OpenSSL 1.0.2r 26 Feb 2019
Is contained false
Is homebrew false
Is installed via Fabric.app false
Xcode Path /Applications/Xcode.app/Contents/Developer/
Xcode Version 11.2

System Locale

Variable Value
LANG en_US.UTF-8
LC_ALL en_US.UTF-8
LANGUAGE

fastlane gems

Gem Version Update-Status
fastlane 2.135.2 ✅ Up-To-Date

Loaded fastlane plugins:

Plugin Version Update-Status
fastlane-plugin-automated_test_emulator_run 1.6.0 ✅ Up-To-Date
fastlane-plugin-versioning_android 0.1.0 ✅ Up-To-Date
Loaded gems
Gem Version
did_you_mean 1.3.0
bundler 2.0.1
etc 1.0.1
CFPropertyList 3.0.1
public_suffix 2.0.5
addressable 2.7.0
atomos 0.1.3
babosa 1.0.3
claide 1.0.3
colored 1.2
colored2 3.1.2
highline 1.7.10
commander-fastlane 4.4.6
declarative 0.0.10
declarative-option 0.1.0
digest-crc 0.4.1
unf_ext 0.0.7.6
unf 0.1.4
domain_name 0.5.20190701
dotenv 2.7.5
emoji_regex 1.0.1
excon 0.68.0
multipart-post 2.0.0
faraday 0.17.0
http-cookie 1.0.3
faraday-cookie_jar 0.0.6
faraday_middleware 0.13.1
fastimage 2.1.7
gh_inspector 1.1.3
jwt 2.1.0
memoist 0.16.1
multi_json 1.14.1
os 1.0.1
signet 0.12.0
googleauth 0.6.7
httpclient 2.8.3
mime-types-data 3.2019.1009
mime-types 3.3
uber 0.1.0
representable 3.0.4
retriable 3.1.2
google-api-client 0.23.9
google-cloud-env 1.3.0
google-cloud-core 1.4.1
google-cloud-storage 1.16.0
json 2.2.0
mini_magick 4.9.5
multi_xml 0.6.0
plist 3.5.0
rubyzip 1.3.0
security 0.1.3
naturally 2.2.0
simctl 1.6.6
slack-notifier 2.3.2
terminal-notifier 2.0.0
unicode-display_width 1.6.0
terminal-table 1.8.0
tty-screen 0.7.0
tty-cursor 0.7.0
tty-spinner 0.9.1
word_wrap 1.0.0
nanaimo 0.2.6
xcodeproj 1.13.0
rouge 2.0.7
xcpretty 0.3.0
xcpretty-travis-formatter 1.0.0
fastlane-plugin-automated_test_emulator_run 1.6.0
fastlane-plugin-versioning_android 0.1.0

About this issue

  • Original URL
  • State: closed
  • Created 5 years ago
  • Reactions: 1
  • Comments: 19 (6 by maintainers)

Most upvoted comments

OHHHHH… We good now. Got a fix and this will be released in the next version most likely tomorrow 😊 Thanks for all the help and patience ❤️