App: [payment due 2023-12-13] [$500] Remove sideloading of Onyx data for avatar with display name

Coming from https://github.com/Expensify/App/issues/27262

Problem

These methods are anti-patterns because they are most always used for loading data into a component without using withOnyx(). This breaks the data flow of a react application. (data is coming from somewhere that is not props or state and cannot be debugged in react dev tools).

Solution

Switch all references to properly use withOnyx() for components and connect() for libs.

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01c108d0b3568a69c3
  • Upwork Job ID: 1730343269382967296
  • Last Price Increase: 2023-11-30

About this issue

  • Original URL
  • State: closed
  • Created 7 months ago
  • Comments: 16 (12 by maintainers)

Most upvoted comments

@cubuspl42 Could you please review the PR I wrote for this? https://github.com/Expensify/App/pull/32304

@joekaufmanexpensify I will only need your help with payment once this is deployed.

@cubuspl42 offer sent for $500!

PR merged