App: [PAYMENT - 01-16: $1000] Android - Console error when any report is opened - reported by @aneequeahmad
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
- Launch android app.
- Click on any report.
Expected Result:
No console errors
Actual Result:
Console error Warning: Failed prop type: The prop anchorPosition.horizontal is marked as required in PopoverWithMeasuredContent, but its value is undefined.
Workaround:
unknown
Platform:
Where is this issue occurring?
- Android
Version Number: 1.1.94-3 Reproducible in staging?: need repro Reproducible in production?: need repro Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL: Issue reported by: @aneequeahmad Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1661901563422729
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01064e852643baf5f4
- Upwork Job ID: 1610433379500457984
- Last Price Increase: 2023-01-04
About this issue
- Original URL
- State: closed
- Created 2 years ago
- Comments: 77 (57 by maintainers)
@deetergp same to me. I also prefer @Ollyws’s proposal
🎀 👀 🎀 C+ reviewed
Minor correction – JS errors would typically land the user in the error boundary and be logged in Firebase Crashlytics. JS warnings would go into the void, never to be seen again (unless you were looking at JS logs for the release app using Android Studio’s LogCat or something similar)
All sorted, thanks Oliver and Aimane!
@jliexpensify applied thanks
PR was merged and deployed to prod on Jan 9. Issue title needs updated accordingly.
All yours @aimane-chnaif, let’s see if we can get it merged within three days!
@deetergp @abekkala @johncschuster @jliexpensify Pretty please make sure that your issues correctly have the
buglabel on them if we’re actively looking for proposals.Bugwas just added to this issue, so before it was not on the WAQ initiative radar, but now it is. Then given that the bug is well over 30 days old, it’s immediately something that we’ve got to prioritize as a result.👋 @Ollyws needs to be assigned to this issue right? Is there a PR to link as well, yet?
Yeah, it sounds like @Ollyws’s proposal, which would make it more consistent across the platforms, is the right way to go here.
@aimane-chnaif On web, we have an issue with the context position when moving from pressable to longPressGuster so we map the gusterEvent to PressEvent and this fixes issue for us . on native we do not have this issue since the menu doesn’t depend on the position as @aneequeahmad said. we can make the anchorPosition.horizonta not required in this case.
but I prefer @Ollyws Propsal because we should send the correct event in native also in case we need to add something on
onSecondaryInteractiondependent on the position (or event)for native. and our componentsPressableWithSecondaryInteractionwill have the same function with the same arguments on native and web.reviewing @aneequeahmad’s proposal shortly
@aneequeahmad Based on your investigation it does look like you’re right and we can make it optional. Let’s go with your proposal and thanks for the deep dive!
@abekkala There is another bug reported https://expensify.slack.com/archives/C01GTK53T8Q/p1665657234159879 Do you want me reopen this bug?