App: [Payment due 3-7][$500] [MEDIUM] Connect Bank Account - No limit for entering amount in transition field

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: v1.4.12-0 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:

Action Performed:

Open the app
Login with any account
Go to Settings -> Workspaces -> Open any WS or create it -> Bank account -> Connect manually
Use our Fake Test account and Save and Continue through all these steps:

Routing 011401533
Account Number 1111222233331111
Company Name create any name, address, phone, tax ID, company type, incorporation date
Personal Info create any name, address, SSN can be 3333
Go through the Onfido step of uploading an ID/passport

When you finish the flow - the modal asks for 3 amounts of test transactions
There is no character limit on the 3 test transaction fields of the Test Transactions page

Expected Result:

Limit for entering an amount in the transition field presents

Actual Result:

No limit for entering amount in transition field

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/93399543/b57c04cb-7db8-40dc-959f-1a7850f5949e

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01ec80ed70582379a7
Upwork Job ID: 1735304593582518272
Last Price Increase: 2024-01-04
Automatic offers:

abdulrahuman5196 | Reviewer | 0
ZhenjaHorbach | Contributor | 0

About this issue

Original URL
State: closed
Created 7 months ago
Comments: 64 (43 by maintainers)

Most upvoted comments

Oh, this can definitely be external. @ZhenjaHorbach’s proposal you reviewed earlier looks good. @ZhenjaHorbach are you still interested in taking on this issue?

If not, we’ll open this up to new proposals!

Hello ) I’m interested )

ZhenjaHorbach on Feb 22, 2024

@NikkiWines I agree I think we can put this on hold for the refactor and fix as a polish there

mountiny on Jan 11, 2024

I was still unable to get a account in pending state. Anyways I code modified and came to the test transactions page for testing.

@ZhenjaHorbach 's proposal here https://github.com/Expensify/App/issues/33065#issuecomment-1855951686 looks good and works well. It was the first to suggest maxLength prop to fix the issue.

🎀 👀 🎀 C+ Reviewed

abdulrahuman5196 on Jan 11, 2024

@Christinadobrzyn Thank you )

ZhenjaHorbach on Dec 21, 2023

Proposal

Updated

Added an Alternative approach with another const limiting the text field to few characters for better UX

neonbhai on Dec 14, 2023

@sfurqan2 Thank you for the comment, it does seem like 50 might be too much for the verification transaction amount, but I’ve suggested the limit since we use this const globally for form character limit. Let’s see if the C+ team has thoughts on this while reviewing.

neonbhai on Dec 14, 2023