App: [HOLD for regression test] Bank account information is editable after reaching Personal information step

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

On iOS or android, navigate to Settings > Workspace > Add bank account
Complete the steps until you reach the Personal information step
Tap < to navigate back to Company information
Verify that Company name and Tax ID can be edited
Tap < and then Continue with setup
Verify that Routing number and Account number can be edited

Expected Result:

Company name, Tax ID, Routing number and Account number should not be editable once the user reaches the Personal information step

Actual Result:

Company name, Tax ID, Routing number and Account number are editable once the user reaches the Personal information step

Workaround:

N/A

Platforms:

Which of our officially supported platforms is this issue occurring on?

Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop

Version Number: Reproducible in staging?: Reproducible in production?: If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation Expensify/Expensify Issue URL: Issue reported by: Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01f0615bf33b37eff9
Upwork Job ID: 1620501620879507456
Last Price Increase: 2023-01-31

About this issue

Original URL
State: closed
Created a year ago
Comments: 20 (14 by maintainers)

Most upvoted comments

If no regressions arise, payment will be issued on 2023-02-13. 🎊

This is internal and @aimane-chnaif was the C+ for review. Should be flat payment of $1000 for that.

~I just invited @aimane-chnaif to the job in Upwork.~ @aimane-chnaif is paid ✅

michaelhaxhiu on Feb 28, 2023

Next steps:

Requesting the buddy check on new QA steps in slack here
Then I’ll cc @Expensify/applauseleads in the draft GH and assign applausebot
Close this GH

michaelhaxhiu on Feb 28, 2023

RN TextInput doesn’t prevent editable when disabled, while react-native-web TextInput does. So I’d say this issue came from the native behavior of RN TextInput. I don’t think any PR caused this regression but just missed during disabled implementation in our TextInput - https://github.com/Expensify/App/pull/1268.

aimane-chnaif on Feb 19, 2023