App: [HOLD for retest] Remove html from Close Account errors
Problem:
In the past, we didn’t show errors that occurred when a user tries to close their account. Instead, we displayed a generic error modal. As of this issue: https://github.com/Expensify/App/issues/11341, we’re planning to get ride of that modal and show the error that occurred. Some of these error messages have <p> before / after the error message (example), which doesn’t look good in NewDot
Solution
Let’s make sure that Close Account error messages that are shown in NewDot look good!
About this issue
- Original URL
- State: closed
- Created 2 years ago
- Comments: 20 (15 by maintainers)
Hey @robertjchen I wasn’t aware of this issue until I saw it in your Slack WAQ status. I’m currently reviewing this PR which is solving this issue.
Oh nice, thanks for the heads up! I’ve added this GH issue to the list in the PR (which doesn’t seem to be tied to an issue at the moment) and will re-test things once it goes out. Will add a HOLD for now 👍
Ok sweet I added this to WAQ
@trjExpensify let me know if there’s something else we were discussing about inline errors vs not that you’d like a reply on, I’m a bit lost with that part of the convo sorry 😅
That said, I do wonder if it’s better to not solely focus on the close account errors, but instead, errors more generally. I can only imagine that this problem with HTML formatting is going to surface in more parts of the app. I pretty much bet it is.
In general, I think this is a good candidate for WAQ, because the refactors precede WAQ from a roadmap perspective, and that makes this an existing issue that should be fixed.
I’m fined being tagged! It’s good to keep track of these kinds of discussions. Also tagging @trjExpensify as we have alternating holiday time between now and the end of the year, and will be subbing in and out for each other.