App: [HOLD for payment 2024-04-15] [$250] Remove NewRequestAmountPage.js and copy any changes since Nov 27 into IOURequestStepAmount.js
This is a part of https://github.com/Expensify/App/issues/29107. You can look at that issue for more context behind the cleanup process.
Problem
The app has two redundant components:
Old Component: NewRequestAmountPage
New Component IOURequestStepAmount
Solution
Following the examples (example 1, example 2), the Old Component needs to be completely removed from the codebase
- Look at the history of the Old Component
- If there are any changes since Nov 27, 2023 which have not been added to the New Component, copy those changes
- Replace all uses of the Old Component with the New Component
- Remove all traces of Old Component
- Be sure to update all routes and navigation to use the new
:actionparam (instead of being hard-coded with"create") - Update any logic like
isEditingto use the new action param from the route
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01400d372c60004a9e
- Upwork Job ID: 1747632925329993728
- Last Price Increase: 2024-01-24
- Automatic offers:
- DylanDylann | Contributor | 28128915
- dukenv0307 | Contributor | 28135067
About this issue
- Original URL
- State: closed
- Created 5 months ago
- Comments: 44 (28 by maintainers)
@lschurr This is a refactoring task, we don’t need regression here.
@lschurr Let’s remove hold label
@dukenv0307 Please update PR
As discussed here, we need to use IOURequestStepAmount in the create/edit flow for both request money and split bill flow
@dukenv0307’s proposal is the first one that covers all cases. Let’s go with his proposal
🎀 👀 🎀 C+ reviewed