App: [HOLD for payment 2024-04-15] [$250] Remove MoneyRequestConfirmPage.js and copy any changes since Nov 27 into IOURequestStepConfirmation.js
This is a part of https://github.com/Expensify/App/issues/29107. You can look at that issue for more context behind the cleanup process.
Problem
The app has two redundant components:
Old Component: MoneyRequestConfirmPage
New Component IOURequestStepConfirmation
Solution
Following the examples (example 1, example 2), the Old Component needs to be completely removed from the codebase
- Look at the history of the Old Component
- If there are any changes since Nov 27, 2023 which have not been added to the New Component, copy those changes
- Replace all uses of the Old Component with the New Component
- Remove all traces of Old Component
- Be sure to update all routes and navigation to use the new
:actionparam (instead of being hard-coded with"create") - Update any logic like
isEditingto use the new action param from the route
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01d384157eb0d34e8a
- Upwork Job ID: 1747632941224689664
- Last Price Increase: 2024-01-17
- Automatic offers:
- DylanDylann | Contributor | 28109099
About this issue
- Original URL
- State: closed
- Created 5 months ago
- Comments: 49 (24 by maintainers)
I think we can go with option 2 to push work parallelly. I ignored updating these on the PR thinking these components are not used anymore. I tested a few but I guess I missed some.
This is not a bug but a code refactor. Bug-zero checklist does not apply. cc: @adelekennedy
@adelekennedy This issue is no more on Hold. In fact, the PR for this is merged. Please fix the title.
If we donβt have an eta for option 1 then I agree that option 2 sounds fine here.
Agreed!
Looks like @DylanDylann has a more complete proposal.
π π π C+ reviewed