App: [HOLD for payment 2024-04-15] [$250] [SelectionList refactor] [Wave Collect] Extract checkbox design and placing outside the BaseListItem component to specific list item components.

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Coming from this issue: https://github.com/Expensify/App/issues/35717 and discussed it on Slack.

We recently refactored the SelectionList component extracting list item components like UserListItem, RadioListItem and TableListItem and asking the parent component to decide which list item component should be used by the SelectionList. There is also a BaseListItem component used by all of these newly extracted item components that holds some common part of the code.

Unfortunately this component still encapsulate how the checkbox used in the list item looks like and where it’s placed, so the goal of this issue is to extract defining checkbox outside the BaseListItem and move this responsibility to specific list item components.


Version Number: Reproducible in staging?: Reproducible in production?: If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Slack conversation:

Action Performed:

Break down in numbered steps

Expected Result:

Describe what you think should’ve happened

Actual Result:

Describe what actually happened

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01e7cfec47d64461f0
  • Upwork Job ID: 1767895235204546560
  • Last Price Increase: 2024-03-13
  • Automatic offers:
    • DylanDylann | Contributor | 0
    • shubham1206agra | Contributor | 0
Issue OwnerCurrent Issue Owner: @Christinadobrzyn

About this issue

  • Original URL
  • State: closed
  • Created 4 months ago
  • Comments: 26 (17 by maintainers)

Most upvoted comments

@shubham1206agra since @burczu is already working on some other wave collect task today and on Friday, would you fancy handling this task too given you have context?

@Christinadobrzyn I don’t think we need a regression test for this issue because this is a refactor task

I can take over as C+