App: [HOLD for payment 2024-03-29] [$250] [Wave Collect] [Workflows] Clean up the isAutoApprovalEnabled flag

Problem

We use the isAutoApprovalEnabled flag to decide if the approval toggle should be on or off in Workflows page https://github.com/Expensify/App/blob/f84219f187f9960df17c584e7c8b10feee77f27f/src/pages/workspace/workflows/WorkspaceWorkflowsPage.tsx#L137

We should however use a comparison to the policy.approvalMode as we do here to define if the auto approval is enabled. It is true when the approval mode is set to basic.

The isAutoApprovalEnabled property is not passed from the backend, it should be removed for now.

This property exists, but its used in different way and we can bring it to the app later.

Solution

Use the approvalMode property to determine the toggle state

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01573ee41af24d66fa
  • Upwork Job ID: 1769144226309750784
  • Last Price Increase: 2024-03-19
Issue OwnerCurrent Issue Owner: @slafortune

About this issue

  • Original URL
  • State: closed
  • Created 3 months ago
  • Comments: 17 (8 by maintainers)

Most upvoted comments

$250 to @hoangzinh for this this one

Accepted. Thanks @slafortune

No need for the checklist here