App: [HOLD for payment 2024-03-29] [$500] [Wave Collect] [Ideal Nav] Incorrect animation direction on Wallet and Troubleshooting page

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.44-7 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause -Internal Team Slack conversation:

Issue found when executing PR https://github.com/Expensify/App/pull/37078

Action Performed:

Pre-requisite: user must be logged in and have an Expensify card assigned

Go to Settings > Wallet
Tap on Expensify card
Tap on the back button
Tap on the avatar to open the account settings
Tap about
Tap troubleshoot
Then Tap <until you reach LHN
Observe the sliding behavior

Expected Result:

A transition animation from left to right should appear (going back to previous page)

Opening each page account settings, about and troubleshootshould slige from the right overtop of the previous page and When pressing < button the page should slide away to the right

Actual Result:

A transition animation from right to left appears (as if it were a new page, not a previous one)

When pressing back button Troubleshoot page, About page slides in from the right, again, overtop Troubleshoot Similarly pressing back button again, Profile slides in from the right Finally, pressing back button, Account Settings slides away to the right which is the correct behavior

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/1b7bfa84-f639-41ed-808d-aded99903c2d

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01588c7a6a3b8f24cb
Upwork Job ID: 1762991723171692544
Last Price Increase: 2024-03-12

Issue Owner

Current Issue Owner: @allroundexperts

About this issue

Original URL
State: closed
Created 4 months ago
Comments: 49 (31 by maintainers)

Most upvoted comments

This is worth fixing imo cause it’s very disorienting for the animation to go forward when in reality you’re going back. I also recon this should be a reasonably quick fix as it looks like a regression.

The expected behavior is that the screen animates off screen to the right when tapping back.

dubielzyk-expensify on Mar 12, 2024

@GandalfGwaihir by narrow view I meant deeplink to the page on mobile safari for example in new tab, what will the < button lead to

mountiny on Mar 12, 2024

@apeyada @GandalfGwaihir Can we please get a proposal which treats this on all the pages there you can find the same issue? We do not want to be create issues for each individual page. As part of the proposal, can you also list all the other pages which suffer with this issue? Thanks!

mountiny on Mar 12, 2024

Agree.

cc @luacmartins @mountiny @trjExpensify as I think this is related to the weird goBack bugs we’ve seen - not sure if we have another issue that is tracking those improvements or if we should treat this as a separate bug.

shawnborton on Mar 12, 2024