App: [HOLD for payment 2024-03-26] [HOLD on E/E #347391][$500] [HIGH] for Collect: Show "Unapprove" report action in NewDot

Related to https://github.com/Expensify/Expensify/issues/364085

Flow:

Pre-testing steps

  1. Create a new collect policy on OldDot and;
    1. Enable scheduled submit with a frequency of Instant (this should happen by default with Expensify accounts, or accounts on paidPolicyInstantSubmit beta)
    2. Make sure the approval mode is “Submit & Approve”
    3. Invite an additional user to the policy to play the member role in these testing flows
  2. Run the following script in the chrome console (in OldDot, when the workspace Settings page is open) to enable the policy for workspace creation for a paid plan.
    p = Policy.getCurrent();
    p.policy.isPolicyExpenseChatEnabled = "true";
    p.save();
    

Test steps

  1. In OldDot: As submitter, make sure ^ new workspace is your “Active” / default workspace
  2. In OldDot: As submitter, create a report and add an expense
  3. In OldDot: As Admin, approve the report - then Unapprove the report
  4. In NewDot: As both accounts, view the expense report & verify you can see both of these report actions:
    1. <admin> final approved this report
    2. <admin> unapproved this report

Currently we’re blocked on 4 ^ - the <admin> unapproved this report report action does not appear, even though the report action exists in Onyx

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~012cccf392c943b52d
  • Upwork Job ID: 1755224934075211776
  • Last Price Increase: 2024-02-07

About this issue

  • Original URL
  • State: closed
  • Created 5 months ago
  • Comments: 26 (19 by maintainers)

Most upvoted comments

So far I like this plan ^ but I’m also waiting on a few internal discussions to wrap up before we move forward here

@twisterdotcom I accepted the offer. Can you help to approve the payment please? Thanks.

Done! Again, could take an hour to show.

Nice, added you! Might take up to an hour to show.

Yup, sorry, we had those discussions and currently landed on the solution in the PR which is slightly different. I was trying to do this myself, but I reached out to a C+ for some help finishing it off.