App: [HOLD for payment 2024-03-06][$500] [Simplified Collect][Members] WorkspaceMembersPage: Members list redesign
Implement WorkspaceMembersPage: Members list redesign from the Simplified Collect: Profile, Members, Categories design doc
Issue Owner
Current Issue Owner: @burczuUpwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01f11d2f24fdf84777
- Upwork Job ID: 1755659075046100992
- Last Price Increase: 2024-02-08
About this issue
- Original URL
- State: closed
- Created 5 months ago
- Comments: 36 (26 by maintainers)
Commits related to this issue
- Merge pull request #37000 from burczu/refactor/35712-selection-list-refactor #35712 selection list refactor — committed to Expensify/App by luacmartins 4 months ago
@burczu Correct, lets make the refactor of the Selection list so you can pass in customized “cells” in a separate PR
The PR is now published and ready for review.
I don’t have strong feelings about whether or not this should be a totally new component or extend an existing one. Part of me thinks its a bit cleaner to keep it as its own component as we’ve seen what happens when we make design/style changes to the SelectionList and how that cascades into other places. So my OCD brain likes keeping them separate at least. Either way, probably a good discussion to bring to Slack!
@burczu I think this is a viable option. Can you do it in a separate PR such that the current renderItem behaviour stay default which we can overwrite if we need this to behave differently?
Hmmm… I need to think about it, cause the
SelectioListis quite complicated and simply wrapping it with props and styles may not be that easy…Or maybe
SelectionTable? LikeSelectionListis a list that allows selection, we will have a table we will use for selection…Correct, the table view would be a totally different component.
Cool, we haven’t planned to update the design of those to the “table list” view we designed to be used for the new Members, Categories, Tags etc pages.
CC: @mountiny as well for vis.
Not overdue - I’m working on this issue right now.
Hi! I’m Bartek from Callstack - expert contributor group. I’ll work on this issue so please assign me. Thank you.