App: [HOLD for payment 2024-03-07] [$500] [HIGH] [Instant Submit] for Collect: Allow `Request Money` from expense reports on paid, instant submit workspaces

Bugs found via testing steps found in this doc

Flow:

Pre-testing steps

Create a new collect policy on OldDot and;
1. Enable scheduled submit with a frequency of Instant (this should happen by default with Expensify accounts, or accounts on paidPolicyInstantSubmit beta)
2. Invite an additional user to the policy to play the member role in these testing flows
Run the script stated here (in OldDot, when the workspace Settings page is open) to enable the policy for workspace creation for a paid plan.
```
p = Policy.getCurrent();
p.policy.isPolicyExpenseChatEnabled = "true";
p.save();
```

Test steps

In OldDot: As submitter, create a report
In NewDot: As submitter, open policy expense chat -> expense report
Click + Actions (next to ReportActionCompose - not the global create + green button)
Verify you see “Request Money”
Click Request Money, make a request, and make sure it works correctly

Currently we’re blocked on 4 ^ - the “Request money” option does not show, I see:

Screenshot 2024-02-05 at 3 50 10 PM

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~017a306e71b6f19bb2
Upwork Job ID: 1754502730371850240
Last Price Increase: 2024-02-19
Automatic offers:

Ollyws | Reviewer | 0
rojiphil | Contributor | 0

About this issue

Original URL
State: closed
Created 5 months ago
Comments: 42 (29 by maintainers)

Most upvoted comments

Regression Test Proposal

Precondition:

    1. Use a Collect Workspace
    2. Set scheduled submit frequency to Instant

Steps:

    1. Create a new Expense Report with one manual money request.
    2. Navigate to the Expense Report.
    3. Verify that on clicking composer FAB button, the menu displays Request money option. —> Test 1
    4. Click on Request money and generate a new manual request.
    5. Verify that the newly generated Money Request action is generated in the same Expense Report —> Test 2
    6. Verify that the Context Menu for the generated Money Request action displays Delete request option —> Test 3
    7. Click on the generated Money Request action to navigate to the Transaction Thread Report of the money request.
    8. Verify that the header menu displays Delete request option —> Test 4

Do we agree 👍 or 👎

Ollyws on Mar 7, 2024

Ok seems like that’s enough to be going on with, @rojiphil’s proposal LGTM.

🎀👀🎀 C+ reviewed

Ollyws on Feb 19, 2024

@Victor-Nyagudi sure thing! Please DM me in slack with the email you’d like to be added to the beta 👍

Beamanator on Feb 19, 2024

Thanks @rojiphil for reproducing!

I understand that the reports are instantly submitted in this case.

Correct

But I also wonder if this is intentional as we do not allow Request money on submitted reports.

In the past correct - because users got to manually choose when to submit their reports - usually when they’re ready for the admin to approve the report, so it would make sense that we don’t want them to request additional money from that report.

However now, since reports are instantly submitted, we want submitters to be able to keep adding money requests to that report - because otherwise we’d only ever be able to have 1 expense / money request per report, see what i’m saying?

Beamanator on Feb 17, 2024

Good question @rojiphil - you need to be on the paidPolicyInstantSubmit beta - you can DM me in Slack (or NewDot) and I’ll add you to the beta 😄

Beamanator on Feb 8, 2024