App: [HOLD for payment 2024-03-04] [$250] Remove MoneyRequestCategoryPage.js and copy any changes since Nov 27 into IOURequestStepCategory.js
This is a part of https://github.com/Expensify/App/issues/29107. You can look at that issue for more context behind the cleanup process.
Problem
The app has two redundant components:
Old Component: MoneyRequestCategoryPage
New Component IOURequestStepCategory
Solution
Following the examples (example 1, example 2), the Old Component needs to be completely removed from the codebase
- Look at the history of the Old Component
- If there are any changes since Nov 27, 2023 which have not been added to the New Component, copy those changes
- Replace all uses of the Old Component with the New Component
- Remove all traces of Old Component
- Be sure to update all routes and navigation to use the new
:actionparam (instead of being hard-coded with"create") - Update any logic like
isEditingto use the new action param from the route
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01aa1b22b861ac0e42
- Upwork Job ID: 1747632761920925696
- Last Price Increase: 2024-01-24
- Automatic offers:
- DylanDylann | Contributor | 28129737
- dukenv0307 | Contributor | 28130978
About this issue
- Original URL
- State: closed
- Created 5 months ago
- Comments: 38 (20 by maintainers)
I will update after returning from the traditional holiday on the 15th.
As discussed here, we need to use
IOURequestStepCategoryin the create/edit flow for both request money and split bill flow@brunovjk I appreciate your proposal with detailed implementation but your proposal doesnβt all cases as above discussion
@dukenv0307 Your proposal look good to me
π π π C+ reviewed
Please add a proposal for the changes that are necessary (I know I gave a brief overview, but your proposal should cover more details as I copy/pasted that into at least a dozen issues).