App: [HOLD for payment 2023-09-06] [$1000] mweb - Inconsistency: `Copy Link` context menu item does not show on the attachment message when it is opened over the attachment in mweb|web

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open a DM with any user in NewDot.
  2. Send a attachment message.
  3. Long press over the attachment to open the context menu.

Expected Result:

On mweb, it should show copy link item as well when opened over the attachment same like native application. We should either shown for both mWeb and native or hide on both. I think better would be to show it as there is less space for the user to open the full context menu for attachment(which is opened when user long presses the empty space side to the attachment).

Actual Result:

On mweb, copy link menu item is not shown when menu is opened over the attachment. This is inconsistent with the native iOS and Android.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.28-3

Reproducible in staging?: y

Reproducible in production?: y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

https://github.com/Expensify/App/assets/93399543/90ef3010-6f86-4fea-bfe0-6e7f174b56ed

Screenshot_20230622_154047_Chrome

Expensify/Expensify Issue URL:

Issue reported by: @parasharrajat

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686904574870779

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0152b793902d18fd0b
  • Upwork Job ID: 1673348174719672320
  • Last Price Increase: 2023-07-17

About this issue

  • Original URL
  • State: closed
  • Created a year ago
  • Comments: 112 (88 by maintainers)

Most upvoted comments

I do apologize for everyone. I got confused about the expected result, so updated previous approval comment.

Now re-evaluating proposals

As this is still a beta feature, a regression test is not needed for now.

I don’t think we should ignore the steps due to this reason. Or do you have any reference to some discussion where you confirmed this?

I don’t have any reference. But this doesn’t affect production users yet. I don’t think it’s late to add regression test step after message deep link is implemented and beta is removed.

Sorry I should have clarified the expected behavior when offload

Screenshot 2023-08-10 at 5 25 47 PM

When right click/long press A, C, “Copy link” should show When right click/long press B, “Copy link” should not show

Here, right click is for web context menu, long press is for mobile context menu

This already works perfect on web. The fix is only for native.

@flaviadefaria can you please update Expected Result in OP accordingly?

Ok, I see. Can you please update your comment to clarify that?

I’d like to take this as C+ based on discussion

@0xmiroslav May I kindly ask what your expectations are for the solution?