App: [HOLD for payment 2023-09-06] [$1000] App crashes on iOS simulator on open

Action Performed:

Break down in numbered steps

Pull the latest main
Run npm run ios
Check that the app crashes with an unhandled promise error

Platforms:

Which of our officially supported platforms is this issue occurring on?

Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop

Version Number: the latest main branch Reproducible in staging?: Nop Reproducible in production?: Nop If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers): N/A Logs: N/A Notes/Photos/Videos: Expensify/Expensify Issue URL: N/A Issue reported by: @hayata-suenaga Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1693020712748639

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~017fd401adeff84c58
Upwork Job ID: 1695589561700159488
Last Price Increase: 2023-08-27
Automatic offers:

shubham1206agra | Contributor | 26347760

About this issue

Original URL
State: closed
Created 10 months ago
Comments: 29 (13 by maintainers)

Most upvoted comments

@allroundexperts @hayata-suenaga PR ready

shubham1206agra on Aug 27, 2023

Checklist

The PR that introduced the bug has been identified. Link to the PR: https://github.com/Expensify/App/pull/25753
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/25753#discussion_r1302827467
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: I don’t think a discussion is needed here because this was a small oversight from the reviewer / author of the PR.
Regression test not needed since this was related to the one off TS migration.

allroundexperts on Sep 10, 2023

don’t know why melvin assigned two bug-zero members…

anyway, @slafortune I apologize situation with this issue looks a little confusing

@allroundexperts is the C+ member who took care of this issue (they did pull request review) @shubham1206agra is the contributor who made the pull request

More context

I created the issue because this was urgent problem
I approved a proposal before C+ approved it because this issue needed to be solved urgently
I unassigned an auto-assigned C+ and assigned another C+ @allroundexperts who was online at that time and had the context for the issue

hayata-suenaga on Aug 27, 2023