App: [HOLD for payment 2023-09-06] [$2000] Dev: Web - Console error on click of Next button in 2FA

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Go to Settings > Security > Two-factor authentication
Click on copy button and click on Next button
Scan the qr code in authenticator app
Enter six digit code
Click on Next button

Expected Result:

It should not show any console error

Actual Result:

Console error appears (Failed prop type: Invalid prop forwardedRef supplied to withOnyx(Component).)

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop

Version Number: 1.3.40-5 Reproducible in staging?: n Reproducible in production?: n If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation

https://github.com/Expensify/App/assets/93399543/9a290511-15ae-480b-bd0e-c428cae3da9c

Expensify/Expensify Issue URL: Issue reported by: @gadhiyamanan Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689328521600739

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01d58d7cdae12240f0
Upwork Job ID: 1684614195949875200
Last Price Increase: 2023-08-08
Automatic offers:

aimane-chnaif | Reviewer | 26032740
kushu7 | Contributor | 26032742
gadhiyamanan | Reporter | 26032744
tienifr | Contributor | 26054370

About this issue

Original URL
State: closed
Created a year ago
Comments: 65 (44 by maintainers)

Most upvoted comments

As this is not urgent issue, I think we can still wait until holding PR deploy to production. Hope it won’t happen again but since it’s big change, there’s possibility that could be reverted due to critical issues.

aimane-chnaif on Aug 20, 2023

Sure, let’s remove hold and @tienifr please raise app PR cc: @hayata-suenaga

aimane-chnaif on Aug 24, 2023

Not overdue

muttmuure on Aug 14, 2023

Maybe we can put this on hold untill #24041 gets merged?

yes, we should

aimane-chnaif on Aug 11, 2023

Thanks @hannojg @aimane-chnaif @hayata-suenaga @tienifr Maybe we can put this on hold untill #24041 gets merged?

kushu7 on Aug 11, 2023

yeah for the latest only version to work you have to make this important change:

Screenshot 2023-08-11 at 08 31 33

Onyx will be updated to the latest version in this PR:

https://github.com/Expensify/App/pull/24041

(The PR that was linked earlier got reverted)

hannojg on Aug 11, 2023

@tienifr when you raise a PR, also bump react-native-onyx version. Our changes got merged.

kushu7 on Aug 11, 2023

@aimane-chnaif PR is up: https://github.com/Expensify/react-native-onyx/pull/296

cc @hayata-suenaga

kushu7 on Aug 9, 2023

nice suggestion @aimane-chnaif

But we’re actually migrating the entire application to TypeScript soon, so forwardRef will have type arguments in place in the same file as the component wrapped by forwardRef.

This is the example code: https://react-typescript-cheatsheet.netlify.app/docs/basic/getting-started/forward_and_create_ref/#:~:text=%3B } }-,forwardRef%3A,-import { forwardRef

hayata-suenaga on Aug 9, 2023