App: [HOLD for payment 2023-07-17] [$1000] Web - App throws 'No content to add' error if we send empty alias for email

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Open the app
Open any report
Type in a link with empty alias eg: [](google.com)
Observe that app handles it well
Send email with empty alias eg: [](test@test.com)
Observe that app throws ‘No content to add’ for step 5 message

Expected Result:

App should handle empty alias for email in similar way like it does for link

Actual Result:

App throws ‘No content to add’ error for email with empty alias

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop

Version Number: 1.3.30.0

Reproducible in staging?: y

Reproducible in production?: y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

https://github.com/Expensify/App/assets/93399543/3efe4b24-22e0-47e5-9758-5bae899a4dac

https://github.com/Expensify/App/assets/93399543/b68bed52-6612-4012-9223-1ffaf656b18d

Expensify/Expensify Issue URL:

Issue reported by: @dhanashree-sawant

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686755882619169

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~012e72288a82e6fae6
Upwork Job ID: 1671920286239043584
Last Price Increase: 2023-06-29

About this issue

Original URL
State: closed
Created a year ago
Comments: 73 (37 by maintainers)

Most upvoted comments

Technically, this PR was merged in 3 days. There was some back and forth in the Contributor assignment which the bot didn’t know. The real assignment to the right contributor happened https://github.com/Expensify/App/issues/21234#issuecomment-1619738189 2 days back.

cc: @laurenreidexpensify

parasharrajat on Jul 6, 2023

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@parasharrajat] The PR that introduced the bug has been identified. Link to the PR: https://github.com/Expensify/expensify-common/pull/464
[@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/expensify-common/pull/464/files#r1266522664
[@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: it was missed during testing. No new steps needed
[@parasharrajat] Determine if we should create a regression test for this bug. Yes
[@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Steps

Go to a chat and add the following comment

[](concierge@expensify.com)
[   ](concierge@expensify.com)
[   

 ](concierge@expensify.com)

Verify that a. Only emails inside () are parsed as email links b. [], () and spaces(including line break) inside [] are not parsed
Click to edit the comment
Verify that the initial draft is the same as the original input.

Do you agree 👍 or 👎 ?

parasharrajat on Jul 18, 2023

We have already shared our opinion above. If you want to share the payment with anyone, it’s your choice but that won’t be done from our side as we only offer payments via Upwork, and in the absence of an Upwork account, we don’t have any way of paying up.

parasharrajat on Jul 4, 2023

@eh2077 Yeah.

parasharrajat on Jul 4, 2023

@parasharrajat Thanks for reviewing proposals.

I’m open to share the bounty with @YacineF0001 , like 50/50. I’d also suggest to let @YacineF0001 make the PR which should be his first contribution to the App! If speed bonus is qualified, then it will be compensated to him only. Hope team will take this into consideration.

eh2077 on Jun 28, 2023

@parasharrajat Thanks for your review. I hope you take care of my latest proposal. I addressed about auto-test cases to be fixed and added more. Without it, i think it can’t be perfect proposal.

YacineF0001 on Jun 27, 2023

Hey everyone. Thanks for the updates. I will review them as soon as possible.

parasharrajat on Jun 26, 2023