App: [HOLD for payment 2023-07-17] [$1000] Web - Log in - Inconsistency between signin button and 2FA button

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Go to settings -> security -> 2FA
Copy/ download codes and continue
Meanwhile download the authenticator application. Now, Scan the QR.
Now type the generated code.
Notice that the “loading sign along with the next button” is displayed as disabled before moving to the next page. ( even when the correct code is typed)
However, if similar steps are followed (i.e after typing magic code ) on the signing page, “the loading bar on sign-in button” is shown enabled.

Expected Result:

Consistency between the buttons. i.e. after typing the correct magic code on singin page or the 2FA code on the authentication page, buttons should either be enabled or disabled on both pages.

Actual Result:

Next button on authentication page is shown disabled before moving to next page, even when the correct 2FAcode is entered.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop

Version Number: 1.3.28.3

Reproducible in staging?: yes

**Reproducible in production?😗*yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

https://github.com/Expensify/App/assets/93399543/73eb4b42-5b1c-4e6d-acf9-18a6eda920d9

https://github.com/Expensify/App/assets/93399543/43b9d7d6-7d8e-495e-9192-ef1a04497759

Expensify/Expensify Issue URL: @ashimsharma10

Issue reported by: https://expensify.slack.com/archives/C049HHMV9SM/p1686219682890139

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01b8ad74604f91854d
Upwork Job ID: 1671877459838341120
Last Price Increase: 2023-06-29

About this issue

Original URL
State: closed
Created a year ago
Comments: 30 (15 by maintainers)

Most upvoted comments

Payment has been issued to @tienifr and @mollfpr. I’ll get the regression test issue going shortly.

johncschuster on Jul 19, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.38-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/22151

If no regressions arise, payment will be issued on 2023-07-17. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter - @ashimsharma10
Contributor that fixed the issue - @tienifr
Contributor+ that helped on the issue and/or PR - @mollfpr Note for BZ: the issue is not eligible for a bonus -JS

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

melvin-bot[bot] on Jul 22, 2023

@mollfpr I’m working on it. The PR will be ready in 1 to 2 hours

tienifr on Jul 3, 2023

Sorry for the delay @tienifr 🙏

I’m okay with useImperativeHandle and I don’t see any drawback for now. @johncschuster the proposal looks good to me 🚀

🎀 👀 🎀 C+ reviewed!

mollfpr on Jun 30, 2023