App: [HOLD for payment 2023-07-17] [$1000] Dev: Console error appears when opening Workspace Members Page

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Go to Settings -> Workspaces
Select any workspace -> Members
Refresh the app

Note: without refresh also it can be reproducible.

Expected Result:

No console error

Actual Result:

Error appearing: Warning: Failed prop type: Invalid prop option.keyForList of type number supplied to OptionRow, expected string.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop

Version Number: n/a Reproducible in staging?: n/a Reproducible in production?: n/a If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation

Console error on invite member.webm

Expensify/Expensify Issue URL: Issue reported by: @daordonez11 Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1687887087153099

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~013423b04ca2e860f4
Upwork Job ID: 1674868972150136832
Last Price Increase: 2023-06-30

About this issue

Original URL
State: closed
Created a year ago
Comments: 37 (17 by maintainers)

Most upvoted comments

Yup it’s all clear! I always wanna keep things straight 🫡

daordonez11 on Jul 21, 2023

oh, i see. i thought you were both getting reporting bonuses for this one. I’ve sent $1750 to @Pujan92 - so i think we’re all set here!

maddylewis on Jul 21, 2023

Sent $1500 offer to @Pujan92
Sent $250 offer to @daordonez11

maddylewis on Jul 21, 2023

Yeah! I think @Pujan92 total is 1750. He has a bonus for urgency and reporting!

daordonez11 on Jul 19, 2023

@daordonez11 Yes it was sent accidentally, sorry for the confusion. Please reject as the offer was made in error.

cc: @maddylewis Update @Pujan92 as reported, thanks!

Santhosh-Sellavel on Jul 3, 2023

Someone should review this offer! @Pujan92 should get the report offer as well! Mine was later.

daordonez11 on Jul 3, 2023

@Pujan92 I’ve checked your comment and @maddylewis’s too here. As it’s triaged, made external, and ready to move forward let’s handle it here.

@maddylewis We need to award reporting bonus to @Pujan92 only as they reported it first!

Santhosh-Sellavel on Jul 2, 2023

@Pujan92 ($1500 auto payment via Upwork)

@maddylewis I think I am yet to receive this. Could you plz check once on it? Just to inform I haven’t received an automatic offer earlier and have not applied to that job which is expired now.

Pujan92 on Jul 21, 2023

@maddylewis I rejected reporting, finally @Pujan92 himself did the first report as well.

daordonez11 on Jul 19, 2023

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@Santhosh-Sellavel] The PR that introduced the bug has been identified. Link to the PR:

[@Santhosh-Sellavel] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/21237/files#r1265665581

[@Santhosh-Sellavel] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Should be caught based on checklist

[@Santhosh-Sellavel] Determine if we should create a regression test for this bug. N/A

[@Santhosh-Sellavel] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. N/A

[@maddylewis] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

We don’t need a separate regression test here, as we used to look for console errors normally!

cc: @Li357 Let me know if differ on any of the above, thanks!

Santhosh-Sellavel on Jul 17, 2023

🎯 ⚡️ Woah @Santhosh-Sellavel / @Pujan92, great job pushing this forwards! ⚡️

The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

when @Pujan92 got assigned: 2023-07-03 15:19:17 Z
when the PR got merged: 2023-07-06 13:16:44 UTC

On to the next one 🚀

melvin-bot[bot] on Jul 6, 2023

@Santhosh-Sellavel @Li357 PR is ready for review!

Pujan92 on Jul 4, 2023

Agree we should stick with just a string proptype, and I prefer an explicit coercion with String than string interpolation. @Pujan92 all yours!

Li357 on Jul 3, 2023

Dupe of https://github.com/Expensify/App/issues/21611

Pujan92 on Jun 29, 2023