App: [HOLD for payment 2023-06-23] [$1000] valid html code displays 'this is beginning...' and invalid html code displays weird symbol in LHN for few seconds

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Open the app
Open any report
Send valid html code. eg:  
Observe the message in LHN
Send invalid html code. eg: 
Observe the message in LHN

Expected Result:

App should display the message as it is in LHN

Actual Result:

App displays ‘This is beginning…’ message for valid HTML code and weird emoji for invalid HTML code for few seconds in LHN

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop

Version Number: 1.3.19-6 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation

https://github.com/Expensify/App/assets/43996225/12284b7c-b522-44f0-bf31-c5c872deb5a9

https://github.com/Expensify/App/assets/43996225/78e6cc99-09f3-4e9f-931f-374441e0ffc3

Expensify/Expensify Issue URL: Issue reported by: @dhanashree-sawant Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1685097977437509

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0114e290337f545c10
Upwork Job ID: 1663626267506884608
Last Price Increase: 2023-05-30

About this issue

Original URL
State: closed
Created a year ago
Comments: 44 (30 by maintainers)

Most upvoted comments

Paid @dhanashree-sawant for reporting. Closed job in Upwork. Closing this GH.

Christinadobrzyn on Jun 23, 2023

@Christinadobrzyn There will only be reporting payment here. This was a regression issue and handled by the original author and C+ so no payment for C+ and Contributor.

https://github.com/Expensify/App/issues/19789#issuecomment-1593611780

parasharrajat on Jun 22, 2023

The PR that introduced the bug has been identified: https://github.com/Expensify/App/pull/19237
The offending PR has been commented on: https://github.com/Expensify/App/pull/19237#issuecomment-1597040243
A discussion in #expensify-bugs has been started: I’m pretty sure we don’t have much to discuss here, the encoding issue was a thing going for a long time and we started fixing this a couple of weeks ago, this is just a propagation of the fix.
Determine if we should create a regression test for this bug: No

s77rt on Jun 19, 2023

Note: This is a regression and the only Pending payment here will be reporting bonus.

parasharrajat on Jun 15, 2023

Opened PR - https://github.com/Expensify/App/pull/20443

alitoshmatov on Jun 8, 2023

@alitoshmatov @therealsujitk Let’s keep the discussion in this issue.

@alitoshmatov For E/App we need a PR that removes outdated htmlDecode for plain text.

s77rt on Jun 7, 2023

@stephanieelliott Since this is a regression, It is being handled in https://github.com/Expensify/App/issues/17658.

we can take down the job here and assign @s77rt to handle it as C+.

parasharrajat on Jun 7, 2023

Yes I think we should wait. I’ll update the title

stitesExpensify on May 31, 2023

Very similar to #19539. If we can get the logic that the server is using we can prevent similar issues from coming up in the future.

therealsujitk on May 30, 2023