App: [HOLD for payment 2023-06-23] [$1000] strikethrough message is displayed with double strikes in inline codeblock

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Open the app
Open any report
send strikethrough message in inline code block eg: ~Test~

Expected Result:

App should only display single strike on text when we send message within ~~ as it normally does for all other type of text

Actual Result:

App displays double strike on text when we send single backtick inline codeblock inside ~~

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop

Version Number: 1.3.17-0 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation

https://github.com/Expensify/App/assets/43996225/5b7d4637-b224-44f6-9418-d5abd4661ffa

https://github.com/Expensify/App/assets/43996225/b0652eeb-3c80-464c-b48c-27ae4a975f49

Expensify/Expensify Issue URL: Issue reported by: @dhanashree-sawant Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1684591177526859

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~017d3349f2ca4f1a37
Upwork Job ID: 1663940475067867136
Last Price Increase: 2023-06-07

About this issue

Original URL
State: closed
Created a year ago
Comments: 35 (18 by maintainers)

Most upvoted comments

Summary:

A proposal is chosen, if approved by engineering (Paulo), the BZ member will assign the contributor.

I’m reassigning (SO) because I will be OOO until June 14. Thanks!

Once I return from OOO if the chore is still outstanding, I will take over any remaining action items.

isabelastisser on Jun 7, 2023

PR is up! @0xmiroslav @PauloGasparSv

getusha on Jun 10, 2023

Ah good catch! @isabelastisser can you please re-assign engineer?

0xmiroslav on Jun 7, 2023

Thanks for the proposals everyone. @getusha’s proposal looks good to me. Other proposals cause regressions - one breaks font, one breaks native

cc: @tgolen 🎀 👀 🎀 C+ reviewed

0xmiroslav on Jun 7, 2023

reviewing proposals today

0xmiroslav on Jun 5, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

strikethrough styling is duplicate sending ~code~

What is the root cause of that problem?

On the web we have HTML renderer which will apply the strike through styling for del tag but for the native side we have to handle it within the styling of the current text component.

https://github.com/Expensify/App/blob/36fe848418c606a07211dd60ab19501af360e98d/src/styles/styles.js#L71-L74

and on the web the styling will be duplicated due to the above factor.

What changes do you think we should make in order to solve the problem?

We should omit textDecorationLine from props.textStyle this will insure we don’t have any duplicate styling

_.omit(props.textStyle, 'textDecorationLine')

What alternative solutions did you explore? (Optional)

getusha on May 31, 2023