App: [HOLD for payment 2023-06-23] [$250] Migrate ACHContractStep.js to function component

Class Component Migration

Filenames

src/pages/ReimbursementAccount/ACHContractStep.js
- type: React.Component
- has state values: true
- has refs: false
- has context: false
- lifecycle methods: none

Task

We currently have some class components in our codebase that we would like to refactor to a function component.
Here’s a link with some general advice on how to refactor a class component to a function component: https://react.dev/reference/react/Component#alternatives
If you need additional guidance, please ask in #expensify-open-source
Test for any regressions and verify that there are no breaking changes

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~010f2532da31096ca1
Upwork Job ID: 1666022067592908800
Last Price Increase: 2023-06-06

About this issue

Original URL
State: closed
Created a year ago
Comments: 31 (17 by maintainers)

Most upvoted comments

Done

slafortune on Jun 26, 2023

Yep, no problems otherwise @multijump, we appreciate your contributions! We will move forward with PR reviews for both PRs.

Also, if you’re interested in contributing, we have tons of open jobs beyond the Class Component Migration project that you can find here

grgia on Jun 7, 2023

Thanks @multijump 👍 Offer sent

slafortune on Jun 26, 2023

@multijump I’m having a hard time seeing what profile would be yours - when there isn’t a name to match, it makes it hard. How should I be searching for you?

I am sorry for your hard time. @slafortune Yes, it’s me, Oleh K. Thanks.

multijump on Jun 23, 2023

@allroundexperts seeing as both PRs are up, there’s no point in unassigning just for someone else to duplicate the work. There are tons of these issues still open, so let’s focus on getting them done. That said, @multijump can you please confirm that you understand the rules from now on? For our migration project, you cannot take more than one issue simultaneously, please merge your first issue before moving on to the next.

@allroundexperts are you alright with moving forward with this decision? Please let me know if you feel strongly the other way.

@grgia I’m good with that!

allroundexperts on Jun 7, 2023

@multijump The guidelines state that you can work on 1 migration issue at a time and should wait for your previous PR to be merged before you ask for a new one.

Nikhil-Vats on Jun 7, 2023

@multijump all yours!

grgia on Jun 6, 2023