App: [HOLD for payment 2022-12-02] [$1000] [Bug] Pressing escape when a popover is open closes the chat and the page gets stuck in the middle - reported by @Puneet-here
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
- Decrease the screen size
- Go to any chat
- Click on actions (the ➕ sign at the left side of message input)
- Press escape
Expected Result:
Only the popover should be closed
Actual Result:
The popover closes but the chat also gets closed and then it gets stuck in the middle of chat and chat list Also. On web staging v1.2.16-4 and when doing the steps, the popover did not close, the chat closed and user was not able to leave the popover (had the LHN on the background) and had to refresh the page to get to working state
Additionally, this should be resolved in the About section --> Copy To Clipboard page
Workaround:
unknown
Platform:
Where is this issue occurring?
- Web
- Desktop App
Version Number: 1.2.15-0 Reproducible in staging?: Y Reproducible in production?: Y Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL: Issue reported by: @Puneet-here Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1663088510944699
About this issue
- Original URL
- State: closed
- Created 2 years ago
- Comments: 61 (37 by maintainers)
Update: paid @Puneet-here and @eVoloshchak in Upwork.
@s77rt, you have a pending offer from me, please accept it first, and I will be able to take the next steps. I messaged you in Upwork with more instructions too. Thanks!
This is not something caused by our codebase, rather it’s a conflict between react-navigation and react-native-modal
You’re right, weird, changes didn’t take place until I cleared the cache and restarted the computer, even though it was hot reloading
@s77rt’s proposal works well and looks good 🎀👀🎀 C+ reviewed!
@Julesssss, what should we do? Open a PR in
react-native-modalor apply a patch?@richdev1124 you’ll need to submit a proposal first, and then get selected. Please see our Contributing guides for more help.
Update: paid @s77rt !
All set!
@Julesssss, is this task completed? Please let me know when I can close the issue. Thanks!
@isabelastisser, I have applied on upwork for the reporting compensation.
@isabelastisser Applied
https://expensify.slack.com/archives/C049HHMV9SM/p1670612750620769
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
Oh I see, thank you
Hey @s77rt. Thanks for the analysis and write-up.
The patch solution makes sense, but we avoid platform-specific logic, as explained here. I’d be happy to review an updated proposal that applies this rule.
Hey @huzaifa-99, we’re definitely interested in solutions that align with accessibility. But we’re not specifically focusing on this as a priority yet.
@isabelastisser reassigning to you while I’m gone to keep it doubling!
Hey @adelekennedy, for now we’re awaiting a proposal. Once we’re settled on a solution the cause will likely become apparent. Then we’ll make sure that tests are added in the PR.
Also the issue is found on
About section --> Copy To ClipboardPopover.Current assignee @Julesssss is eligible for the External assigner, not assigning anyone new.
@mountiny was able to reproduce here! I think this a real one