App: [Hold for payment 2022-12-06 $250] Default rooms are not grayed out when creating a new workspace while offline

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Sign in with any account
Go offline
Click the green plus at the bottom, New workspace. Or if you already have a workspace click the avatar in the header to open the settings, click on a workspace, click the 3 vertical dots at the top, New workspace.

Expected Result:

The default rooms, #admins, #announce, and the workspace expense chat should be grayed out in the LHN and on the search page. When navigating to any of these rooms the whole room should be grayed out (50% opacity).

Actual Result:

The default rooms are not grayed out (50% opacity).

Workaround:

Ignore it

Platform:

All platforms

Web
iOS
Android
Desktop App
Mobile Web

Version Number: v1.2.18-10 Reproducible in staging?: Yes Reproducible in production?: Yes Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos:

https://user-images.githubusercontent.com/26260477/198112025-cf40f3df-9dbb-4ceb-b93b-bd8a97156a69.mov

Expensify/Expensify Issue URL: Issue reported by: @neil-marcellini Slack conversation:

View all open jobs on GitHub

About this issue

Original URL
State: closed
Created 2 years ago
Comments: 62 (50 by maintainers)

Most upvoted comments

@tienifr - Just a friendly bump to response to the comment from @eVoloshchak here. Thanks

I am out of the office tomorrow. If there is an urgent need on this GH from a BugZero team member, please post in #expensify-open-source for assistance.

strepanier03 on Nov 11, 2022

Thank you @eVoloshchak- I’ll update the OG checklist with your comments for clarity.

I’ve also paid your contract in UpWork.

strepanier03 on Dec 10, 2022

Paid @tienifr, thank you!

strepanier03 on Dec 9, 2022

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@eVoloshchak / @MonilBhavsar] The PR that introduced the bug has been identified. Link to the PR: I think it’s https://github.com/Expensify/App/pull/10723, but i wouldn’t say it ‘introduced’ the bug
[@eVoloshchak / @MonilBhavsar] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/10723#issuecomment-1346347503
[@eVoloshchak / @MonilBhavsar] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@strepanier03] A regression test has been added or updated so that the same bug will not reach production again. Link to the GH issue for creating the test here: We have an item in the checklist that should have prevented this: I turned off my network connection and tested it while offline to ensure it matches the expected behavior. Not sure we can catch this type of bug sooner with anything but thorough testing

MonilBhavsar on Dec 13, 2022

The associated PR was deployed to production earlier last week in this release. Not sure why i didn’t post the message here. We can do the checklist manually and close this issue as it has already been 7 days since it was deployed to production

MonilBhavsar on Dec 6, 2022

Still on staging.

I am OoO for jury duty tomorrow. If immediate action is needed on this GH please post in #expensify-open-source for assistance, thank you.

strepanier03 on Dec 2, 2022

Waiting for deploy…

MonilBhavsar on Nov 28, 2022

PR is merged!

MonilBhavsar on Nov 24, 2022

Update: This is actively being worked on in the PR.

I am out of the office Wednesday-Sunday and will return Monday. If urgent help is needed for this GH please post your request and the URL in #expensify-open-source for some additional help.

strepanier03 on Nov 23, 2022

Hi, @tienifr! I’ve found a bug and left a comment on the PR, please check it out

eVoloshchak on Nov 21, 2022

Aaah, sorry about that @MonilBhavsar! I misunderstood where the conversation was at and thought you were on board with the solution because of the discussion about the rooms. I will wait for more explicit approval from the CME moving forward.

strepanier03 on Nov 18, 2022