App: [HOLD for payment 2022-11-29] Redbrick path broken for Settings > Workspaces

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


The red dots showing the path of an error is interrupted

Action Performed:

Using an account that is a domain

  1. Create a workspace in New Dot
  2. Go to old dot and set the workspace as the preferred policy of a domain’s group
  3. In new dot, try to delete the workspace, this will cause the API to throw an error
  4. Check that the red bricks path is broken at the Settings level. The Workspaces entry should have a red dot.

https://user-images.githubusercontent.com/87341702/199128893-e4f819ab-7df2-428c-81c5-9ff939e46643.mov

Expected Result:

The should have been a red dot next to the Workspaces entry in the Settings menu

Actual Result:

No red dot there

Workaround:

The user can use the app as normal, it is just bad feedback on where the error is.

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: Reproducible in staging?: Reproducible in production?: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation Expensify/Expensify Issue URL: Issue reported by: Slack conversation:

View all open jobs on GitHub

About this issue

  • Original URL
  • State: closed
  • Created 2 years ago
  • Reactions: 1
  • Comments: 32 (20 by maintainers)

Most upvoted comments

I typically use like web/mobile, but you can open the JS console in the incognito browser > Network tab > then next to the wifi symbol switch the dropdown to Offline to follow the steps here:

image

Which PR caused this bug?

My PR here - https://github.com/Expensify/App/pull/11784 caused the bug

What do you think we could have done differently in the original PR to prevent this bug from being introduced

Not sure, I missed testing for this usecase. There are a number of error usecases and while we did test for RBR I didn’t realize this one would show up visually different.

and who is responsible for adding the appropriate test?

I think its best for @aldo-expensify to add this scenario to our regression tests since he found it. Is that alright with you aldo?