App: [$1000] Chat - App removes strikethrough formatting on copy and resend for code block
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
- Open the app
- Open any report
- Send strikethrough code block eg: ~
Hello~ - Hover on message and click on copy to clipboard OR edit the message and copy the message
- Send the copied message and observe that app removes strikethrough format from the code block
Expected Result:
App should keep the format of text same when we copy it to clipboard or copy from edit message and resend the message
Actual Result:
App does not keep the format of strikethrough on code block on copy to clipboard or copy from edit message and resend the message
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
Version Number: 1.3.41-2 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/93399543/0c2b5085-106a-465d-bf58-467a0d0425bf
https://github.com/Expensify/App/assets/93399543/afd39161-3b5a-4f17-8a7d-b5a694ab46eb
Expensify/Expensify Issue URL: Issue reported by: GH handle - @dhanashree-sawant Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689525870441879
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~012fc66a9c82073e51
- Upwork Job ID: 1681045679677927424
- Last Price Increase: 2023-09-11
About this issue
- Original URL
- State: closed
- Created a year ago
- Comments: 90 (65 by maintainers)
@Skalakid we can find striking through in code block on discord. and italic and bold as well
I am finally free from critical issues so I will be able to check the slack thread and update you. I haven’t reviewed any proposals yet because I want to check if we are setting correct parsing rules.
I opened a Slack thread but it didn’t receive the needed interest so I will try to push it a little more. Currently, team is busy getting critical features out before the upcoming conference so it will take a few days before we can really move forward.
Also, I don’t want to make this change at this stage to prevent unexpected bugs while the App is being used by real users. So it means we have time till the conference to decide the correct solution.
Hey I’m Michał from Software Mansion, an expert agency, and I will help close this issue out 😄
Hey @parasharrajat , You can have a look at my proposal and see if it looks good. I had tried the changes and it was giving expected results.
I will share an update soon.
Sounds good! LMK if there’s anything else I can help with as you review the proposals here.
Note to me: I think the root cause here is incorrect parsing of
prerule And I think that issue was stated after this PR https://github.com/Expensify/expensify-common/pull/496.