App: [$1000] Chat - Error message displayed when using 2 rows with four backticks
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Issue found when executing PR https://github.com/Expensify/App/pull/13941
Action Performed:
- Go to staging.new.expensify.com
- Log in with any account
- Select any conversation
- Type 2 rows with 4 brackets
Expected Result:
No error message should be seen; message should match Slack’s behavior (a single backtick on two lines, within a <pre> block)
Actual Result:
Error message displayed when using 2 rows with four brackets
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
Version Number: 1.2.49.0
Reproducible in staging?: Yes
Reproducible in production?: No
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~014c69ea8eddb49796
- Upwork Job ID: 1611395276911079424
- Last Price Increase: 2023-01-06
About this issue
- Original URL
- State: closed
- Created a year ago
- Comments: 39 (33 by maintainers)
Hey @Prince-Mendiratta (and @aimane-chnaif) I think that makes sense to me - you were helpful in getting this sorted out. We can definitely send over a bit of a bonus! cc @isabelastisser
I’m going to go ahead and close this since I believe everyone is paid and we’ve passed 7 days - should anyone disagree (or I do not have the right information), feel free to reopen!
Update: Invited @aimane-chnaif and @Prince-Mendiratta to this job in Upwork.
Maybe
Externallabel confused you. We should have removed it and addedInternalinstead.Oh, @isabelastisser this is internal issue. @dangrous is internal engineer and I am C+. No contributor assigned here.
Both of y’all are right on the cause! Not sure what we want to have as expected behavior here, though. I’ll bring it up in Slack and see what we think.
Update: @aimane-chnaif and @Prince-Mendiratta were paid. All set!
@aimane-chnaif let us know what you think of that regex change! I can’t really review since it was my code haha. I think the main issue will be whether or not it adds any bugs for other uses of backticks in messages.
We can sort out the payment/bonus/PR author stuff discussed in Slack once we confirm that this is the direction we want to go in.