brave-browser: unable to exclude sites from the a-c table

Description

We’re still getting reports from the community that even after https://github.com/brave/brave-browser/issues/1693 being released in 0.58.21 which was the hotfx 3, users are still having issues excluding websites from the a-c.

Steps to Reproduce

N/A… We currently don’t really have any STR. We should try working with some users that are experiencing this to see if we can either get their profiles or see if they’re receiving an errors in the browser console.

Actual result:

Users can’t exclude websites from the a-c table under Rewards.

Expected result:

Users should be able to exclude publishers from the a-c table under Rewards

Reproduces how often:

I’m not sure as we don’t really have STR yet.

Brave version (brave://version info)

Brave	0.58.21 Chromium: 71.0.3578.98 (Official Build) (64-bit)
Revision	15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}

Reproducible on current release:

Does it reproduce on brave-browser dev/beta builds?

I’m not sure as we don’t really have STR yet. We’ll need more information from the users that are still experiencing this issue.

Additional Information

CCing @brave/legacy_qa @NejcZdovc

About this issue

Original URL
State: closed
Created 5 years ago
Comments: 18 (4 by maintainers)

Links to this issue

Release Channel version [0.63.48] is live!

Most upvoted comments

Verified passed with

Brave	0.63.14 Chromium: 73.0.3683.75 (Official Build) dev(64-bit)
Revision	909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS	Mac OS X

Verified test plan from https://github.com/brave/brave-core/pull/1760
Encountered https://github.com/brave/brave-browser/issues/3783 while testing
Verified able to remove sites from auto contribute table and restore them

Verification passed on

Brave	0.63.14 Chromium: 73.0.3683.75 (Official Build) dev (64-bit)
Revision	909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS	Windows 10 OS Build 17134.523

Used test plan from https://github.com/brave/brave-core/pull/1760 Also tested excluding and including of site in a-c table

Verification passed on

Brave	0.63.15 Chromium: 73.0.3683.75 (Official Build) dev (64-bit)
Revision	909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS	Linux

Verified test plan from https://github.com/brave/brave-core/pull/1760
Encountered https://github.com/brave/brave-browser/issues/3783 while testing

LaurenWags on Mar 21, 2019

@Brave-Matt @kjozwiak

Just an update on my observations - I was just playing around with this more and stepping through the code when I noticed there does seem to be a problem excluding sub-domains when you have already excluded the domain. This does appear to be separate from the latency issue I’m also seeing.

My guess is this is from the check on publisherKey, instead of url:

if (!state.excluded.includes(publisherKey)) {  
    chrome.send('brave_rewards.excludePublisher', [publisherKey])  
    state.excluded.push(publisherKey)  
    state = {  
        ...state,  
        excluded: state.excluded  
    }  
}

For instance - I took a look at the exclude list as it’s saved to localStorage and I see it’s just publisherKey, which is only the main domain. At some point I excluded google.com successfully but in my a-c list I have mail.google.com showing up as just “google.com” (twice, different bug). So that check I’m guessing fails since it only checks the publisher key which looks to be the same across subdomains…

Top of A-C list in localStorage:

Exclude list in localStorage:

Top of my A-C Table:

MrRobboto on Jan 17, 2019

@LaurenWags looks plausible! In any case, the showing up twice seems unrelated to this issue. I tested the latency issue quite a bit and all the sites I tried to exclude worked perfectly fine and the UI updated perfectly as you’d expect (no double entries for me) - just really bad latency, 10+ seconds on some, not as bad on others. I could imagine it timing out on some sites causing it to fail completely for some people but I did not observe this…

MrRobboto on Jan 15, 2019