brave-browser: Unable to open Ads from Notification center

Description

Unable to open Ads from Notification center

Steps to Reproduce

Set Focus Assist settings to Alarm Only in Windows OS
Clean profile 0.63.40
Enable Rewards
Open brave.com
Verify that Ads notification is displayed under the notification center
Click on the Ads notification

Actual result:

Clicking on the notifications within the notification slide, just dismisses the banner without opening brave or displaying the ad.

Ads

image (5)

Expected result:

The user should be able to open the Ads

Reproduces how often:

Always

Brave version (brave://version info)

Brave	0.63.40 Chromium: 74.0.3729.61 (Official Build) beta (64-bit)
Revision	5df2c8936783bd7575987e45d72a92fcf528496b-refs/branch-heads/3729@{#645}
OS	Windows 10 OS Build 17134.523

Reproducible on current release: NA

Does it reproduce on brave-browser dev/beta builds? Yes

Website problems only:

Does the issue resolve itself when disabling Brave Shields? NA
Is the issue reproducible on the latest version of Chrome? NA

Additional Information

The issue is reported by the community https://community.brave.com/t/unable-to-open-ads-from-notification-area/49199/4

@brave/legacy_qa @tmancey

About this issue

Original URL
State: closed
Created 5 years ago
Reactions: 1
Comments: 40 (1 by maintainers)

Links to this issue

Release Channel 1.3.113

Most upvoted comments

@jsecretan should we reprioritize this to maybe a P3? Seems like we’re getting more +1 from Win users who are running into this. Imagine we’ll want to get this fixed sooner than later.

kjozwiak on May 28, 2019

A few users in Community troubleshooting thread reporting this as well: https://community.brave.com/t/brave-ads-windows-10-troubleshooting/56730/13

Brave-Matt on May 18, 2019

+1 from Community too: https://community.brave.com/t/notification-enabled-but-not-working/49594/63

Is there any particular reason we have this set to P4? Windows users are having enough trouble with ads/notifications as it is – sucks to finally get them up and running only to not be able to view the ads. @rebron

Brave-Matt on May 17, 2019

@lukemulks , yes, the notifications are collected in the notification tray. However, they cannot be opened. Clicking on them just dismisses them without showing any ad.

rivy on May 14, 2019

Verification passed on

Brave	1.3.100 Chromium: 79.0.3945.130 (Official Build) beta (64-bit)
Revision	e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS	Windows 10 OS Version 1803 (Build 17134.1006)

Verified the test plan from brave/brave-core#3084
Verified we no longer see any ads if Focus Assist is set to Alarm Only https://github.com/brave/brave-browser/issues/4102#issuecomment-577847799
More scenarios are tested in https://github.com/brave/brave-browser/issues/3651#issuecomment-577998598

Clean profile:

Ensured ad notifications are NOT shown on windows when Focus Assist is enabled [5016:6316:0124/124645.543:INFO:ads_impl.cc(1148)] Notification not made: Notifications not allowed
Ensured ad notification is shown when Focus Assist is disabled [4428:16072:0124/124905.285:INFO:ads_impl.cc(1305)] Ad notification shown:

Upgrade profile: (Upgrade from 1.2.43 to 1.3.100)

Viewed ads in 1.2.43 ads collected in the notification center when focus assist is enabled --> upgrade to 1.3.100 ads are not shown in 1.3.100, Verified notifications not allowed text message in logs [5652:4820:0124/145717.418:INFO:ads_impl.cc(1148)] Notification not made: Notifications not allowed
Verified ads are shown when focus assist is disabled in an upgraded profile. [9440:11284:0124/150629.389:INFO:ads_impl.cc(1305)] Ad notification shown:

Verification passed on

Brave	1.3.100 Chromium: 79.0.3945.130 (Official Build) beta (64-bit)
Revision	e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS	Windows 10 OS Version 1909

Verified the test plan from brave/brave-core#3084
Verified we no longer see any ads if Focus Assist is set to Alarm Only https://github.com/brave/brave-browser/issues/4102#issuecomment-577847799

GeetaSarvadnya on Jan 27, 2020

As discussed with @tmancey over the slack - there is a change in the behavior as we no longer show ads if notification are not enabled. Also, we won’t get any ads when Focus Assist is set to Alarm Only The detailed test plan is provided in the PR - https://github.com/brave/brave-core/pull/3084

GeetaSarvadnya on Jan 23, 2020

@tmancey Issue is still not fixed. I am not getting any ads when Focus Assist is set to Alarm Only - Ads are not popping up or being displayed under the notification center. Let me know if I am missing anything otherwise, I will log a follow-up issue for it.

GeetaSarvadnya on Jan 22, 2020

@rivy I will update you early next, as will discuss internally. Thank you for the above testing and input. Much appreciated. Terry

tmancey on Dec 14, 2019