zulip: Incorrect placeholder when no deactivated users match filter
As reported on CZO, when no deactivated users match the currently filter in Deactivated tab of Settings > Users, we incorrectly show the placeholder “There are no deactivated users.” Instead, it should be: “No deactivated users match your filters.” (similar to the behavior in the active users tab).
Note:
A simple and straightforward fix for this breaks the search functionality completely. I guess we might need to refactor
ListWidgetcode to handle a combination of filters like we have role and search filters here.
About this issue
- Original URL
- State: closed
- Created 2 years ago
- Comments: 15 (3 by maintainers)
Commits related to this issue
- list_widget: Fix empty_list_message for deactivated users. Before this commit, the active user list was using the `data-empty` attribute to display a message when the filtered user was not found. Ho... — committed to shuklamaneesh23/zulip by shuklamaneesh23 2 years ago
- list_widget: Fix `empty_list_message` for deactivated users. Previously, the placeholder text displayed incorrectly after applying filters. This commit refactors `list_widget` to check if combinatio... — committed to Aditya8840/zulip by Aditya8840 2 years ago
- list_widget: Fix placeholder for unmatched deactivated user filters. Previously, the placeholder text displayed incorrectly after applying filters. This commit refactors `list_widget` to check if co... — committed to Aditya8840/zulip by Aditya8840 2 years ago
- list_widget: Fix placeholder for unmatched deactivated user filters. Previously, the placeholder text displayed incorrectly after applying filters. This commit refactors `list_widget` to check if co... — committed to Aditya8840/zulip by Aditya8840 2 years ago
- list_widget: Fix placeholder for unmatched deactivated user filters. Previously, the placeholder text displayed incorrectly after applying filters. This commit refactors `list_widget` to check if co... — committed to Aditya8840/zulip by Aditya8840 a year ago
- list_widget: Fix placeholder for unmatched deactivated user filters. Previously, the placeholder text displayed incorrectly after applying filters. This commit refactors `list_widget` to check if co... — committed to mreza-kiani/zulip by Aditya8840 a year ago
- list_widget: Fix placeholder for unmatched deactivated user filters. Previously, the placeholder text displayed incorrectly after applying filters. This commit refactors `list_widget` to check if co... — committed to Kishn0109/zulip by Aditya8840 a year ago
- list_widget: Fix placeholder for unmatched deactivated user filters. Previously, the placeholder text displayed incorrectly after applying filters. This commit refactors `list_widget` to check if co... — committed to theofficialvedantjoshi/zulip by Aditya8840 a year ago
@everyone, please don’t try to claim this issue as there is already an active PR by @Aditya8840 for this issue.
Thanks!
Hey @alya , could you please assign this to me manually as zulipbot seems to be having some issue. Thanks!