zulip: Incorrect placeholder when no deactivated users match filter

As reported on CZO, when no deactivated users match the currently filter in Deactivated tab of Settings > Users, we incorrectly show the placeholder “There are no deactivated users.” Instead, it should be: “No deactivated users match your filters.” (similar to the behavior in the active users tab).

Note:

A simple and straightforward fix for this breaks the search functionality completely. I guess we might need to refactor ListWidget code to handle a combination of filters like we have role and search filters here.

CZO thread

About this issue

  • Original URL
  • State: closed
  • Created 2 years ago
  • Comments: 15 (3 by maintainers)

Commits related to this issue

Most upvoted comments

@everyone, please don’t try to claim this issue as there is already an active PR by @Aditya8840 for this issue.

Thanks!

Hey @alya , could you please assign this to me manually as zulipbot seems to be having some issue. Thanks!