zulip: Dialog widget cancel button doesn't look disabled when it should be
The “Cancel” button of dialog widget gets functionally disabled whenever the changes are saved, but in light theme, it doesn’t look disabled visually when it should be, it is probably a CSS styling bug.
While reproducing, turn on throttling from the devtools network tab, since it might be difficult to spot it because the dialog box closes quickly.
Steps to reproduce :-
- Switch to light theme.
- Open the move message dialog and move a message to other stream/topic keeping an eye on the cancel button.
- Click the move message button.
- Cancel button appears to be not disabled (although it isn’t).
About this issue
- Original URL
- State: closed
- Created 3 years ago
- Comments: 16 (7 by maintainers)
Commits related to this issue
- popovers: Refine light mode style for cancel button. Fixes zulip#28803 in this commit, optimized cancel button text color, background color, button border and background when disabled in .dialog_exi... — committed to ASHUVINAYAK1/zulip by ASHUVINAYAK1 3 years ago
- popovers: Refine light mode style for cancel button. Fixes zulip#28803 in this commit, optimized cancel button text color, background color, button border and background when disabled in .dialog_exi... — committed to ASHUVINAYAK1/zulip by ASHUVINAYAK1 3 years ago
- popovers: Fix cancel button style issue. The Cancel button in the dialog widget was not visually disabled in the light theme despite being functionally disabled. Added CSS styling to fix this. Fixes:... — committed to leonorf03/zulip by leonorf03 3 years ago
- popovers: Fix cancel button style issue. The Cancel button in the dialog widget was not visually disabled in the light theme despite being functionally disabled. Added CSS styling to properly visuall... — committed to leonorf03/zulip by leonorf03 3 years ago
@alya Yep, I tested and this bug’s been fixed now