operator: Pipeline deployment deletion can not kick off the reconcile function, leading to no deployment recreation
Expected Behavior
pipeline deployment deletion should kick off reconcile func, so that the pipeline deployment can be recreated.
Actual Behavior
no recreation of deployment, though deployment is registered:
err = c.Watch(
&source.Kind{Type: &appsv1.Deployment{}},
&handler.EnqueueRequestForOwner{
IsController: true,
OwnerType: &op.Config{},
})
if err != nil {
return err
}
Steps to Reproduce the Problem
- install the operator, remove the either deployment of the pipeline
- pipeline deployment can not be revived.
- reconcile func is not called.
Additional Info
About this issue
- Original URL
- State: closed
- Created 5 years ago
- Comments: 24 (20 by maintainers)
Commits related to this issue
- Merge pull request #25 from rupalibehera/update_namesapce Using tkn-aac-sa as SA and using nightly-ci-github-hub-token — committed to nikhil-thomas/tektoncd-operator by rupalibehera 3 years ago
We close it, since it has been resolved. Next, we should make sure the deployment can be recreated after deletion.
@nikhil-thomas Great work, thanks👍
in my opinion, let us wait for the operator-sdk update. it should be an simple change for us.
@vdemeester @sthaha