starship: success_symbol option of the status module is being ignored

Bug Report

Current Behavior

success_symbol option of the status module is being ignored.

Expected Behavior

Show the success_symbol when command succeed as describe in the documentation: “The symbol displayed on program success”

Additional context/Screenshots

 ❯ sh -c 'echo tst; exit 0;'                               
tst

 ❯ sh -c 'echo tst; exit 7;'                               
tst

 ❯                                                    ✗ [7]

Possible Solution

ATM IDK. I will update this issue, if I come up with something.

Environment

  • Starship version: starship 1.4.2 branch: commit_hash: build_time:2022-03-10 18:01:38 +00:00 build_env:rustc 1.59.0
  • Shell type: zsh
  • Shell version: zsh 5.8 (x86_64-apple-darwin21.0)
  • Shell plugin manager: nothing
  • Terminal emulators: iTerm and Alacritty
  • Operating system: MacOS 12.2.1

Relevant Shell Configuration

~
❯ cat ~/.zshrc
eval "$(starship init zsh)"

Starship Configuration

format = " $character"
right_format = "$status "

[character]
success_symbol = "[❯](bold green)"
error_symbol   = "[❯](bold green)"
vicmd_symbol   = "[❮](bold green)"

[status]
style = "fg:blue"
symbol = "[✗](bold red)"
success_symbol = "[✔️](bold green)"
format = '$symbol$success_symbol [\[$int\]]($style) '
disabled = false

About this issue

  • Original URL
  • State: closed
  • Created 2 years ago
  • Reactions: 1
  • Comments: 33 (25 by maintainers)

Most upvoted comments

Oh OK. Hopefully soon 🤞 Thank you for fixing it 🙇‍♂️ You are awesome!! 😄

Will do. Thank you! 🙇‍♂️

Definitely looks like an oversight. I’d suggest making the change you proposed, setting the default success_symbol to be an empty string and outputting success_symbol on non-zero status codes. 👍

Thank you for opening this issue. Good to know I am not alone 😄

I was trying to do the same thing when I first started using starship but I was a noob and thought I am probably doing something wrong so just gave up.