solo: Sail commands don't exit correctly on quit
When running sail commands e.g. sail up inside Solo (Solo is running on the host, not inside sail), and quitting Solo, the sail command don’t terminate.
This means that a command of sail npm run dev leaves vite running inside the container and when starting Solo again it won’t start as the port is already in use.
I suspect that each command needs to be sent an explicit SIGTERM or SIGKILL when q is pressed inside the Solo UI.
About this issue
- Original URL
- State: closed
- Created 2 years ago
- Reactions: 2
- Comments: 15 (6 by maintainers)
@aarondfrancis this is way closer! With
sail up(basicallydocker compose up) it doesn’t allow input but it doesn’t block moving between tabs (this is fine!). Withsail npm run devit still doesn’t kill correct so it won’t restart, but if I usesail npm run dev && sail exec beacon killall nodeas the command I can hit restart twice and it works, which is a big step forward.It also solved an issue running
sail pest(it would break the frame and then redraw after it was done, I suspect similar to ngrok that you mentioned had issues before).At this point it’s totally usable for me.