solo: Adding provider to bootstrap file causes issues deploying to production.
Hey Aaron, love solo.
We’ve installed it in our app, but because it’s a --dev composer dependency, but registers it’s service provider in bootstrap/providers.php, it causes issues when going to production when composer dev dependencies aren’t installed.
I’ve removed it manually from the providers array, which fixes deployment, but then obviously breaks Solo locally.
One solution was to move the Solo::useTheme('dark')->addCommands([ call from the published provider into the AppServiceProvider - but obviously that has the same issue once you remove the --dev from your composer installs.
I think the route to go down here might have to be configuring all this in the config file instead of a published provider. Will fire up a PR if i get time (i’m away the rest of this week, but have friday free), but thought i’d drop this here incase a) i’d missed something or b) it sparked any thoughts in your own mind about how to handle this.
About this issue
- Original URL
- State: closed
- Created 2 years ago
- Reactions: 7
- Comments: 17 (6 by maintainers)
I ran into this issue too and was just checking PR’s and issues to see if anyone else has.
I was also thinking of submitting a PR that has Solo use Laravel’s auto descovery to register itself and pull from
config/solo.phpfor declaring of stuff, for example this is how I have it in mine right now:That way in production the only artifact that still exists for Solo is
config/solo.php.What are your thoughts @aarondfrancis? I can PR this asap.
Excellent, I’ll pull in latest changes and do some testing
@joshmanders for Pail you’ll need 0.2.1, because it still wasn’t quitting.
https://github.com/aarondfrancis/solo/issues/27
Yeah it’s a good question. Solo should be much more compatible with Pint now, including properly killing / cleaning up after Pint. I’ll probably leave the Enhanced one there because it doesn’t require another package, but I’ll give Pint another go locally just to ensure it works
Mmm good point. Ok let’s just fix the service provider stub then. If you want to use a config file you totally can! I’ve got one cooking over here anyway. In due time!
For now, I’ve change the provider stub. Since y’all have already published yours, you’ll have to update it manually. Sorry about that.
Here’s the commit that fixes the stub: https://github.com/aarondfrancis/solo/commit/56cebb137c7a86d9f38dc3a34617dfe0fae1c4d2
Yeah, it’s a temporary workaround to get things working again when deploying to production.
The config approach is probably the best way forward! ✌️
@joshmanders do it, this is what I started doing the other day, but i’ve been on holiday this week.
https://github.com/aarondfrancis/solo/commit/9b24b92b47791547bb8c7fe899fd80bd54bbd348