sidekiq-cron: Cron v1.12.0 is incompatible with Sidekiq v7.3.4
The #set method changed its return value from instance of Sidekiq::Job to instance of ActiveJob::ConfiguredJob, hence we need #perform_later instead of #perform_async.
Not sure if this should go into v2 or v1.12.1.
About this issue
- Original URL
- State: closed
- Created 2 years ago
- Reactions: 9
- Comments: 18 (10 by maintainers)
@paulhklam1122 Please don’t rush an opensource maintainer. When people work for free, they deserve to do it on their own terms.
I pushed a fix in #510. I suggest to keep this issue open until a fixed version of
sidekiq-cronis published, to avoid more issues being opened on the same problem.Closing @leoarnold, v2 is out!
Thank you all! It seems quite stable finally, I’ll launch the v2 during this weekend.
Pull request: https://github.com/sidekiq-cron/sidekiq-cron/pull/511
Thank you for the detailed reply, I realize that tone isn’t translated on text. My apologize, take the time that you need and we all appreciate this library being maintained. It’s wonderful!
Master branch worked for me too, thanks @markets 👍
I’m using the master branch on the last commit (https://github.com/sidekiq-cron/sidekiq-cron/commit/f0ac4038da7b3c6bc09b2c3ca9f0b9979848a95a) in production for a day with success.
Stats:
The history with the JID are present and it is nice, thanks for that feature.
The human readable cron time works well if no timezone. With a timezone, it does not work (eg:
0 6 * * * Asia/Tokyo). [EDIT: the human readable text does not “work” with timezone, see screenshot in another comment below]Thanks a lot for your feedback @leoarnold 👌🏼
Our next move is
v2.0.0.rc3or probably the definitivev2.0.0. I’d like to wait like a couple of weeks more and then 🚀@markets I have a test system running Sidekiq 7.3.4 and Cron f0ac4038da7b3c6bc09b2c3ca9f0b9979848a95a. No problems so far. Keep those release candidates coming.
#510 has been merged, please expedite releasing a new v2.0 as soon as possible please.
I have no plans to release more versions based on the 1.X series. Could you please try the
v2.0.0.rc2?