sidekiq-cron: Incompatible with newer versions of rufus-scheduler

This gem works with rufus-scheduler version 3.4.2 but does not work with version 3.5.0

While using version 3.5.0, attempting Sidekiq::Cron::Job.create calls returns false, and the job is not added.

My only guess to the cause is that according to the changelog, rufus-scheduler now uses fugit to parse durations and cronlines. I looked for instances of parse_time_string and parse_duration_string in this repository, and didn’t find any - so it doesn’t appear that their removal is playing a part here.

About this issue

Original URL
State: closed
Created 6 years ago
Reactions: 23
Comments: 16 (6 by maintainers)

Commits related to this issue

:arrow_down: Downgrade gem "rufus-scheduler" to 3.4.2 Current version 3.5.0 has issues with sidekiq-cron https://github.com/ondrejbartas/sidekiq-cron/issues/199 — committed to ledermann/docker-rails by ledermann 6 years ago
Use directly fugit instead of rufus-scheduler Addresses https://github.com/ondrejbartas/sidekiq-cron/issues/199 Sidekiq-cron is not using rufus-scheduler itself but rather its cron logic which recen... — committed to jmettraux/sidekiq-cron by jmettraux 6 years ago
[gem] Downgrade gem 'rufus-scheduler' to '3.4.2' due issue https://github.com/ondrejbartas/sidekiq-cron/issues/199 — committed to old-guys/nazgrel by jhjguxin 6 years ago
fix sidekiq-cron issue it stopped working due to incompatible new version of rufus-scheduler, see https://github.com/ondrejbartas/sidekiq-cron/issues/199 — committed to moonavw/labman by moonavw 6 years ago
fix sidekiq-cron issue it stopped working due to incompatible new version of rufus-scheduler, see https://github.com/ondrejbartas/sidekiq-cron/issues/199 — committed to moonavw/labman by moonavw 6 years ago

Most upvoted comments

I got around this by adding this to my Gemfile

gem 'rufus-scheduler', '~> 3.4.0'

+24

tataihono on May 27, 2018

+1 this is urgent

+11

tommyalvarez on May 16, 2018

@brianstien Thanks a lot!

I submitted a pull request that aligns Sidekiq-cron on fugit (the parsing lib behind rufus-scheduler >= 3.5 instead of rufus-scheduler).

http://jmettraux.skepti.ch/20180515.html?t=rufus_scheduler_3_5_0_released

jmettraux on May 18, 2018

I just installed version 1.0.0 and it fixed the mentioned error for me

dcdieci on Jul 9, 2018

@jmettraux This problem is affecting us as well. I was able to track down the error you were looking for

jruby-9.1.12.0 :018 > j = ::Sidekiq::Cron::Job.new(:name => "foo", :cron => "* * * * *", :klass => "Foo", :queue => "foo")
 => #<Sidekiq::Cron::Job:0xd332ebc @active_job=false, @active_job_queue_name_prefix=nil, @active_job_queue_name_delimiter=nil, @klass="Foo", @args=[], @status="enabled", @last_enqueue_time=nil, @fetch_missing_args=true, @message={"queue"=>"foo", "class"=>"Foo", "args"=>[]}, @name="foo", @queue="foo", @queue_name_with_prefix="foo", @cron="* * * * *"> 
jruby-9.1.12.0 :019 > j.valid?
 => false 
jruby-9.1.12.0 :020 > j.errors
 => ["'cron' -> * * * * *: uninitialized constant Rufus::Scheduler::CronLine"]

brianstien on May 17, 2018

Any news?

giedriusr on Jun 7, 2018

@lucascaton Yes, people are giving feedback and coming with suggestions at gh-202, gh-209, gh-210, and gh-213. Since it’s not related to “Incompatible with newer versions of rufus-scheduler” (this issue), the conversation is happening elsewhere.

jmettraux on Jul 19, 2018

May I suggest, as well, at

that >= 3.3.0 be replaced by ~> 3.4?

jmettraux on May 17, 2018

Thanks 😃

lucascaton on Jul 20, 2018

Yet another reminder: https://bundler.io/v1.16/guides/updating_gems.html

Updating your dependency gem versions is something you do deliberately, with your back covered by your test suite. http://jmettraux.skepti.ch/20180601.html?t=Gemfile_lock&f=gh

jmettraux on Jun 1, 2018