servo: Crash when running the MotionMark benchmark

This hits an assertion in WR (tested on linux):

./mach run https://browserbench.org/MotionMark/

assertion failed: descriptor.size.width > 0 && descriptor.size.height > 0 (thread WRRenderBackend#0, at /home/fabrice/.cargo/git/checkouts/webrender-c3596abe1cf4f320/c939a61/webrender/src/texture_cache.rs:838)
stack backtrace:
   0:     0x558efd61910c - backtrace::backtrace::trace::h13752643c1b9ba7d
   1:     0x558efd618f42 - <backtrace::capture::Backtrace as core::default::Default>::default::h7d71ba4baaf56702
   2:     0x558efd618f88 - backtrace::capture::Backtrace::new::h51b3adccf40d0f84
   3:     0x558efa9c7a68 - servo::main::{{closure}}::h99a539a58e8f7180
   4:     0x558efd642a83 - std::panicking::rust_panic_with_hook::h75f53ae1ba39714f
                        at libstd/panicking.rs:479
   5:     0x558efc67fc46 - std::panicking::begin_panic::h42fa0f689e0ea6d3
   6:     0x558efc6fccb8 - webrender::texture_cache::TextureCache::update::hfb07f1b1546263ad
   7:     0x558efc58b689 - webrender::resource_cache::ResourceCache::block_until_all_resources_added::h6c6b2397507021a3
   8:     0x558efc648cf5 - webrender::render_backend::Document::render::h8c313f462a9da985
   9:     0x558efc651bef - webrender::render_backend::RenderBackend::update_document::hb7f7577203b62f1f
  10:     0x558efc64baac - webrender::render_backend::RenderBackend::run::heafd46544b1d4818
  11:     0x558efc67f3fe - std::sys_common::backtrace::__rust_begin_short_backtrace::h1c38a6ce002c24e9
  12:     0x558efc67fc75 - _ZN3std9panicking3try7do_call17h48521a3ba896b436E.llvm.14580864019959517563
  13:     0x558efd6542b9 - __rust_maybe_catch_panic
                        at libpanic_unwind/lib.rs:106
  14:     0x558efc59aeb0 - <F as alloc::boxed::FnBox<A>>::call_box::hd16c5364b2a1fad3
  15:     0x558efd62d72a - <alloc::boxed::Box<(dyn alloc::boxed::FnBox<A, Output$u3d$R$GT$$u20$$u2b$$u20$$u27$a$RP$$GT$$u20$as$u20$core..ops..function..FnOnce$LT$A$GT$$GT$::call_once::h3757e4bb61b80a30
                        at /checkout/src/liballoc/boxed.rs:650
                         - std::sys_common::thread::start_thread::h9710965ece577cf4
                        at libstd/sys_common/thread.rs:24
  16:     0x558efd62b9b5 - std::sys::unix::thread::Thread::new::thread_start::h661e40e1cea4ad5b
                        at libstd/sys/unix/thread.rs:90
  17:     0x7f549700f6da - start_thread
  18:     0x7f54955c488e - __clone
  19:                0x0 - <unknown>
ERROR 2018-08-15T01:12:16Z: servo: assertion failed: descriptor.size.width > 0 && descriptor.size.height > 0
called `Result::unwrap()` on an `Err` value: Io(Os { code: 104, kind: ConnectionReset, message: "Connection reset by peer" }) (thread LayoutThread PipelineId { namespace_id: PipelineNamespaceId(1), index: PipelineIndex(1) }, at libcore/result.rs:945)
called `Result::unwrap()` on an `Err` value: Io(Os { code: 32, kind: BrokenPipe, message: "Broken pipe" }) (thread CanvasThread, at libcore/result.rs:945)
stack backtrace:
   0:     0x558efd61910c - backtrace::backtrace::trace::h13752643c1b9ba7d
   1:     0x558efd618f42 - <backtrace::capture::Backtrace as core::default::Default>::default::h7d71ba4baaf56702
   2:     0x558efd618f88 - backtrace::capture::Backtrace::new::h51b3adccf40d0f84
   3:     0x558efa9c7a68 - servo::main::{{closure}}::h99a539a58e8f7180
   4:     0x558efd642a83 - std::panicking::rust_panic_with_hook::h75f53ae1ba39714f
                        at libstd/panicking.rs:479
   5:     0x558efd642629 - std::panicking::continue_panic_fmt::h5f5c2db8ab083e0d
                        at libstd/panicking.rs:390
   6:     0x558efd642525 - rust_begin_unwind
                        at libstd/panicking.rs:325
   7:     0x558efd66469b - core::panicking::panic_fmt::h28ab0e0b2f3bdb57
                        at libcore/panicking.rs:77
   8:     0x558efcab8d4d - core::result::unwrap_failed::he7e56b67caef4b34
   9:     0x558efcaa98dc - webrender_api::api::RenderApi::send_transaction::h5eccd73c8865c423
  10:     0x558efacffef9 - profile_traits::time::profile::h28c74c64475c40a9
  11:     0x558efacc1528 - layout_thread::LayoutThread::perform_post_style_recalc_layout_passes::h4f7fb95c417e3a79
  12:     0x558efacc0dcf - layout_thread::LayoutThread::tick_all_animations::h5c79d2591112a61d
  13:     0x558efacb95ae - layout_thread::LayoutThread::handle_request_helper::h33675a61a715bf4a
  14:     0x558efacb87e3 - layout_thread::LayoutThread::start::he4ea5e26c42e4105
  15:     0x558efad4cc33 - profile_traits::mem::ProfilerChan::run_with_memory_reporting::h23e4af0db10b1755
  16:     0x558efadaf784 - std::sys_common::backtrace::__rust_begin_short_backtrace::hca6e18ab039f2374
  17:     0x558efad852e7 - _ZN3std9panicking3try7do_call17hb724e7ee2c942bc9E.llvm.18254109579811531464
  18:     0x558efd6542b9 - __rust_maybe_catch_panic
                        at libpanic_unwind/lib.rs:106
  19:     0x558efaca9b10 - <F as alloc::boxed::FnBox<A>>::call_box::h6d032580d207cdb7
  20:     0x558efd62d72a - <alloc::boxed::Box<(dyn alloc::boxed::FnBox<A, Output$u3d$R$GT$$u20$$u2b$$u20$$u27$a$RP$$GT$$u20$as$u20$core..ops..function..FnOnce$LT$A$GT$$GT$::call_once::h3757e4bb61b80a30
                        at /checkout/src/liballoc/boxed.rs:650
                         - std::sys_common::thread::start_thread::h9710965ece577cf4
                        at libstd/sys_common/thread.rs:24
  21:     0x558efd62b9b5 - std::sys::unix::thread::Thread::new::thread_start::h661e40e1cea4ad5b
                        at libstd/sys/unix/thread.rs:90
  22:     0x7f549700f6da - start_thread
  23:     0x7f54955c488e - __clone
  24:                0x0 - <unknown>
ERROR 2018-08-15T01:12:16Z: servo: called `Result::unwrap()` on an `Err` value: Io(Os { code: 104, kind: ConnectionReset, message: "Connection reset by peer" })
stack backtrace:
   0:     0x558efd61910c - backtrace::backtrace::trace::h13752643c1b9ba7d
   1:     0x558efd618f42 - <backtrace::capture::Backtrace as core::default::Default>::default::h7d71ba4baaf56702
   2:     0x558efd618f88 - backtrace::capture::Backtrace::new::h51b3adccf40d0f84
   3:     0x558efa9c7a68 - servo::main::{{closure}}::h99a539a58e8f7180
   4:     0x558efd642a83 - std::panicking::rust_panic_with_hook::h75f53ae1ba39714f
                        at libstd/panicking.rs:479
   5:     0x558efd642629 - std::panicking::continue_panic_fmt::h5f5c2db8ab083e0d
                        at libstd/panicking.rs:390
   6:     0x558efd642525 - rust_begin_unwind
                        at libstd/panicking.rs:325
   7:     0x558efd66469b - core::panicking::panic_fmt::h28ab0e0b2f3bdb57
                        at libcore/panicking.rs:77
   8:     0x558efcab8d4d - core::result::unwrap_failed::he7e56b67caef4b34
   9:     0x558efcaa9480 - webrender_api::api::RenderApi::update_resources::h1d405b5fa047c77d
  10:     0x558efc475153 - azure::azure_hl::DataSourceSurface::with_data::h6181e9c998b3fce0
  11:     0x558efc410ed8 - canvas::canvas_data::CanvasData::send_data::hc8be4272848f4e44
  12:     0x558efc412524 - canvas::canvas_paint_thread::CanvasPaintThread::start::{{closure}}::h73060c275dff56f7
  13:     0x558efc405275 - std::sys_common::backtrace::__rust_begin_short_backtrace::he9d2f57106a3163e
  14:     0x558efc406aa7 - _ZN3std9panicking3try7do_call17h531e394c1b9c4854E.llvm.14400003529351726512
  15:     0x558efd6542b9 - __rust_maybe_catch_panic
                        at libpanic_unwind/lib.rs:106
  16:     0x558efc3f1998 - <F as alloc::boxed::FnBox<A>>::call_box::hd0f7628b667440ed
  17:     0x558efd62d72a - <alloc::boxed::Box<(dyn alloc::boxed::FnBox<A, Output$u3d$R$GT$$u20$$u2b$$u20$$u27$a$RP$$GT$$u20$as$u20$core..ops..function..FnOnce$LT$A$GT$$GT$::call_once::h3757e4bb61b80a30
                        at /checkout/src/liballoc/boxed.rs:650
                         - std::sys_common::thread::start_thread::h9710965ece577cf4
                        at libstd/sys_common/thread.rs:24
  18:     0x558efd62b9b5 - std::sys::unix::thread::Thread::new::thread_start::h661e40e1cea4ad5b
                        at libstd/sys/unix/thread.rs:90
  19:     0x7f549700f6da - start_thread
  20:     0x7f54955c488e - __clone
  21:                0x0 - <unknown>
ERROR 2018-08-15T01:12:16Z: servo: called `Result::unwrap()` on an `Err` value: Io(Os { code: 32, kind: BrokenPipe, message: "Broken pipe" })
called `Result::unwrap()` on an `Err` value: Io(Os { code: 104, kind: ConnectionReset, message: "Connection reset by peer" }) (thread LayoutThread PipelineId { namespace_id: PipelineNamespaceId(2), index: PipelineIndex(4) }, at libcore/result.rs:945)
Stack trace for thread "LayoutThread PipelineId { namespace_id: PipelineNamespaceId(1), index: PipelineIndex(1) }"
stack backtrace:
   0:     0x558efd61910c - backtrace::backtrace::trace::h13752643c1b9ba7d
   1:     0x558efd618f42 - <backtrace::capture::Backtrace as core::default::Default>::default::h7d71ba4baaf56702
   2:     0x558efd618f88 - backtrace::capture::Backtrace::new::h51b3adccf40d0f84
   3:     0x558efa9c567a - servo::install_crash_handler::handler::h3da374efccc9dfdb
   4:     0x558efd1ef494 - AsmJSFaultHandler
                        at /home/fabrice/.cargo/registry/src/github.com-1ecc6299db9ec823/mozjs_sys-0.51.4/mozjs/js/src/asmjs/WasmSignalHandlers.cpp:1171
   5:     0x7f549701a88f - <unknown>
   6:     0x558efad952e0 - <std::sync::mpsc::Sender<T> as core::ops::drop::Drop>::drop::h352bcdc24c539e0f
   7:     0x558efaca53bb - core::ptr::drop_in_place::h6bb73710c0bfe147
   8:     0x558efacbd8ad - layout_thread::LayoutThread::handle_request_helper::h33675a61a715bf4a
   9:     0x558efacb87e3 - layout_thread::LayoutThread::start::he4ea5e26c42e4105
  10:     0x558efad4cc33 - profile_traits::mem::ProfilerChan::run_with_memory_reporting::h23e4af0db10b1755
  11:     0x558efadaf784 - std::sys_common::backtrace::__rust_begin_short_backtrace::hca6e18ab039f2374
  12:     0x558efad852e7 - _ZN3std9panicking3try7do_call17hb724e7ee2c942bc9E.llvm.18254109579811531464
  13:     0x558efd6542b9 - __rust_maybe_catch_panic
                        at libpanic_unwind/lib.rs:106
  14:     0x558efaca9b10 - <F as alloc::boxed::FnBox<A>>::call_box::h6d032580d207cdb7
  15:     0x558efd62d72a - <alloc::boxed::Box<(dyn alloc::boxed::FnBox<A, Output$u3d$R$GT$$u20$$u2b$$u20$$u27$a$RP$$GT$$u20$as$u20$core..ops..function..FnOnce$LT$A$GT$$GT$::call_once::h3757e4bb61b80a30
                        at /checkout/src/liballoc/boxed.rs:650
                         - std::sys_common::thread::start_thread::h9710965ece577cf4
                        at libstd/sys_common/thread.rs:24
  16:     0x558efd62b9b5 - std::sys::unix::thread::Thread::new::thread_start::h661e40e1cea4ad5b
                        at libstd/sys/unix/thread.rs:90
  17:     0x7f549700f6da - start_thread
  18:     0x7f54955c488e - __clone
  19:                0x0 - <unknown>
stack backtrace:
   0:     0x558efd61910c - backtrace::backtrace::trace::h13752643c1b9ba7d
   1:     0x558efd618f42 - <backtrace::capture::Backtrace as core::default::Default>::default::h7d71ba4baaf56702
   2:     0x558efd618f88 - backtrace::capture::Backtrace::new::h51b3adccf40d0f84
   3:     0x558efa9c7a68 - servo::main::{{closure}}::h99a539a58e8f7180
   4:     0x558efd642a83 - std::panicking::rust_panic_with_hook::h75f53ae1ba39714f
                        at libstd/panicking.rs:479
   5:     0x558efd642629 - std::panicking::continue_panic_fmt::h5f5c2db8ab083e0d
                        at libstd/panicking.rs:390
   6:     0x558efd642525 - rust_begin_unwind
                        at libstd/panicking.rs:325
   7:     0x558efd66469b - core::panicking::panic_fmt::h28ab0e0b2f3bdb57
                        at libcore/panicking.rs:77
   8:     0x558efbceefbd - core::result::unwrap_failed::hc1af4b85d4051f7b
   9:     0x558efbcfdfc9 - <layout::fragment::Fragment as layout::display_list::builder::FragmentDisplayListBuilding>::build_fragment_type_specific_display_items::h0157d1b492555a25
  10:     0x558efbcfd567 - <layout::fragment::Fragment as layout::display_list::builder::FragmentDisplayListBuilding>::build_display_list_no_damage::h57a7d002b88c1470
  11:     0x558efbcdf077 - <layout::inline::InlineFlow as layout::display_list::builder::InlineFlowDisplayListBuilding>::build_display_list_for_inline::h7b8001df3b0badf0
  12:     0x558efbcf38b0 - layout::traversal::BuildDisplayList::traverse::hd8d61e727e316aec
  13:     0x558efbcf3902 - layout::traversal::BuildDisplayList::traverse::hd8d61e727e316aec
  14:     0x558efbcf3902 - layout::traversal::BuildDisplayList::traverse::hd8d61e727e316aec
  15:     0x558efbcf1b19 - layout::sequential::build_display_list_for_subtree::h9b9f43c9ac4273f2
  16:     0x558efacff795 - profile_traits::time::profile::h28c74c64475c40a9
  17:     0x558efacc1528 - layout_thread::LayoutThread::perform_post_style_recalc_layout_passes::h4f7fb95c417e3a79
  18:     0x558efacbf5b3 - layout_thread::LayoutThread::handle_reflow::h6b0835675a0003b0
  19:     0x558efad007ae - profile_traits::time::profile::h9f1e51aa0fe8cc13
  20:     0x558efacb9b1b - layout_thread::LayoutThread::handle_request_helper::h33675a61a715bf4a
  21:     0x558efacb8581 - layout_thread::LayoutThread::start::he4ea5e26c42e4105
  22:     0x558efad4cc33 - profile_traits::mem::ProfilerChan::run_with_memory_reporting::h23e4af0db10b1755
  23:     0x558efadaf784 - std::sys_common::backtrace::__rust_begin_short_backtrace::hca6e18ab039f2374
  24:     0x558efad852e7 - _ZN3std9panicking3try7do_call17hb724e7ee2c942bc9E.llvm.18254109579811531464
  25:     0x558efd6542b9 - __rust_maybe_catch_panic
                        at libpanic_unwind/lib.rs:106
  26:     0x558efaca9b10 - <F as alloc::boxed::FnBox<A>>::call_box::h6d032580d207cdb7
  27:     0x558efd62d72a - <alloc::boxed::Box<(dyn alloc::boxed::FnBox<A, Output$u3d$R$GT$$u20$$u2b$$u20$$u27$a$RP$$GT$$u20$as$u20$core..ops..function..FnOnce$LT$A$GT$$GT$::call_once::h3757e4bb61b80a30
                        at /checkout/src/liballoc/boxed.rs:650
                         - std::sys_common::thread::start_thread::h9710965ece577cf4
                        at libstd/sys_common/thread.rs:24
  28:     0x558efd62b9b5 - std::sys::unix::thread::Thread::new::thread_start::h661e40e1cea4ad5b
                        at libstd/sys/unix/thread.rs:90
  29:     0x7f549700f6da - start_thread
  30:     0x7f54955c488e - __clone
  31:                0x0 - <unknown>
Stack trace for thread "LayoutThread PipelineId { namespace_id: PipelineNamespaceId(1), index: PipelineIndex(1) }"
stack backtrace:
   0:     0x558efd61910c - backtrace::backtrace::trace::h13752643c1b9ba7d
   1:     0x558efd618f42 - <backtrace::capture::Backtrace as core::default::Default>::default::h7d71ba4baaf56702
ERROR 2018-08-15T01:12:16Z: servo: called `Result::unwrap()` on an `Err` value: Io(Os { code: 104, kind: ConnectionReset, message: "Connection reset by peer" })
   2:     0x558efd618f88 - backtrace::capture::Backtrace::new::h51b3adccf40d0f84
   3:     0x558efa9c567a - servo::install_crash_handler::handler::h3da374efccc9dfdb
   4:     0x7f54954e1f1f - <unknown>
   5:     0x558efa9c5702 - servo::install_crash_handler::handler::h3da374efccc9dfdb
   6:     0x558efd1ef494 - AsmJSFaultHandler
                        at /home/fabrice/.cargo/registry/src/github.com-1ecc6299db9ec823/mozjs_sys-0.51.4/mozjs/js/src/asmjs/WasmSignalHandlers.cpp:1171
   7:     0x7f549701a88f - <unknown>
   8:     0x558efad952e0 - <std::sync::mpsc::Sender<T> as core::ops::drop::Drop>::drop::h352bcdc24c539e0f
   9:     0x558efaca53bb - core::ptr::drop_in_place::h6bb73710c0bfe147
  10:     0x558efacbd8ad - layout_thread::LayoutThread::handle_request_helper::h33675a61a715bf4a
  11:     0x558efacb87e3 - layout_thread::LayoutThread::start::he4ea5e26c42e4105
  12:     0x558efad4cc33 - profile_traits::mem::ProfilerChan::run_with_memory_reporting::h23e4af0db10b1755
  13:     0x558efadaf784 - std::sys_common::backtrace::__rust_begin_short_backtrace::hca6e18ab039f2374
  14:     0x558efad852e7 - _ZN3std9panicking3try7do_call17hb724e7ee2c942bc9E.llvm.18254109579811531464
  15:     0x558efd6542b9 - __rust_maybe_catch_panic
                        at libpanic_unwind/lib.rs:106
  16:     0x558efaca9b10 - <F as alloc::boxed::FnBox<A>>::call_box::h6d032580d207cdb7
  17:     0x558efd62d72a - <alloc::boxed::Box<(dyn alloc::boxed::FnBox<A, Output$u3d$R$GT$$u20$$u2b$$u20$$u27$a$RP$$GT$$u20$as$u20$core..ops..function..FnOnce$LT$A$GT$$GT$::call_once::h3757e4bb61b80a30
                        at /checkout/src/liballoc/boxed.rs:650
                         - std::sys_common::thread::start_thread::h9710965ece577cf4
                        at libstd/sys_common/thread.rs:24
  18:     0x558efd62b9b5 - std::sys::unix::thread::Thread::new::thread_start::h661e40e1cea4ad5b
                        at libstd/sys/unix/thread.rs:90
  19:     0x7f549700f6da - start_thread
  20:     0x7f54955c488e - __clone
  21:                0x0 - <unknown>
Servo exited with return value -4

ping @gw3583

About this issue

  • Original URL
  • State: closed
  • Created 8 years ago
  • Comments: 41 (40 by maintainers)

Commits related to this issue

Most upvoted comments

@dralley I found a smaller test-case for this. The problem happens when we put a 0x0 canvas image in a display list (I add a width/height to the style so this isn’t culled from the display list). This will cause Servo to add the 0x0 image to WebRender which creates that empty texture cache entry (https://searchfox.org/mozilla-central/rev/8526066f548af9ec3ebb462ff73c47ccc183f533/gfx/wr/webrender/src/texture_cache.rs#1472). Later when WebRender tries to update the texture cache it encounters the invalid CacheTextureId.

I’m not exactly sure what Servo should be doing here, but I hope this gives you a good place to start looking!

<canvas id="myCanvas" width="0" height="0" style="width:10px; height:10px;"></canvas>
<script>
var c = document.getElementById("myCanvas");
var ctx = c.getContext("2d");
ctx.clearRect(0, 0, c.width, c.height);
</script>

The canvas image is uploaded to WebRender here: https://github.com/servo/servo/blob/4f5110f34f04c7b0b264a261f63894af61ce24d8/components/canvas/canvas_data.rs#L966-L1005

With the new raqote patch, it runs without crashing (although some benchmarks don’t display properly or at all) until hitting this:

[2020-04-07T14:18:14Z ERROR script::dom::bindings::error] Error at https://browserbench.org/MotionMark/resources/extensions.js:112:13 prefix is undefined

which comes from

    browserPrefix: function()
    {
        // Get the HTML element's CSSStyleDeclaration
        var styles = window.getComputedStyle(document.documentElement, '');

        // Convert the styles list to an array
        var stylesArray = Array.prototype.slice.call(styles);

        // Concatenate all the styles in one big string
        var stylesString = stylesArray.join('');

        // Search the styles string for a known prefix type, settle on Opera if none is found.
        var prefixes = stylesString.match(/-(moz|webkit|ms)-/) || (styles.OLink === '' && ['', 'o']);

        // prefixes has two elements; e.g. for webkit it has ['-webkit-', 'webkit'];
        var prefix = prefixes[1];

        // Have 'O' before 'Moz' in the string so it is matched first.
        var dom = ('WebKit|O|Moz|MS').match(new RegExp(prefix, 'i'))[0];

        // Return all the required prefixes.
        return {
            dom: dom,
            lowercase: prefix,
            css: '-' + prefix + '-',
            js: prefix[0].toUpperCase() + prefix.substr(1)
        };
    },