servo: Crash in StyleThread in RoboHornet benchmark

When trying to pass the robohornet test with standard settings, Servo fell. image

What happened:

➜  servo ./servo http://www.robohornet.org/
[2019-06-21T07:20:26Z ERROR script::dom::bindings::error] Error at http://www.robohornet.org/robohornet.js:357:11 this.benchmarkWindow_ is undefined
[2019-06-21T07:20:38Z ERROR script::dom::bindings::error] Error at http://www.robohornet.org/robohornet.js:357:11 this.benchmarkWindow_ is undefined
[2019-06-21T07:20:51Z ERROR script::dom::bindings::error] Error at http://www.robohornet.org/robohornet.js:357:11 this.benchmarkWindow_ is undefined
Stack trace for thread "StyleThread#2"
stack backtrace:
   0: servo::install_crash_handler::handler::h6507b033053aebc1 (0x5579f2e08446)
   1: _ZL15WasmTrapHandleriP9siginfo_tPv (0x5579f483ca4d)
             at /root/.cargo/git/checkouts/mozjs-fa11ffc7d4f1cc2d/05c7d30/mozjs/js/src/wasm/WasmSignalHandlers.cpp:948
   2: <unknown> (0x7f3a43081f3f)
   3: gfx::font_context::FontContext<S>::font_group::h44c9aab40c157ba6 (0x5579f4a037a4)
   4: layout::text::font_metrics_for_style::h942d00a4846ba57c (0x5579f4a0c469)
   5: std::thread::local::LocalKey<T>::with::h028296a2297aa7b4 (0x5579f4a069d9)
   6: layout::fragment::Fragment::content_inline_metrics::inline_metrics_of_text::ha93d49663ef53470 (0x5579f4a5749a)
   7: layout::fragment::Fragment::content_inline_metrics::h22f69ec7670957e6 (0x5579f4a573b5)
   8: layout::fragment::Fragment::aligned_inline_metrics::h0fd1995d2cf6695e (0x5579f4a5765e)
   9: layout::inline::LineBreaker::push_fragment_to_line_ignoring_text_overflow::h3de209173cfdef2a (0x5579f4a3436e)
  10: layout::inline::LineBreaker::push_fragment_to_line::h4e071ef23cb470d2 (0x5579f4a34114)
  11: <layout::inline::InlineFlow as layout::flow::Flow>::assign_block_size::h5996aae9606578ba (0x5579f4a37d34)
  12: layout::parallel::top_down_flow::h8715fe474d142d92 (0x5579f4a43348)
  13: layout::parallel::top_down_flow::h8715fe474d142d92 (0x5579f4a4352b)
.........
 283: layout::parallel::top_down_flow::h8715fe474d142d92 (0x5579f4a4352b)
 284: profile_traits::time::profile::ha124fd9a770f91d2 (0x5579f4a8322a)
 285: _ZN3std9panicking3try7do_call17hfcd40643c1bce846E.llvm.7282273553544605765 (0x5579f49edfdd)
 286: __rust_maybe_catch_panic (0x5579f5e7a779)
             at src/libpanic_unwind/lib.rs:85
 287: rayon_core::registry::in_worker::hfa214468ecbaa6f9 (0x5579f4a70172)
 288: <std::panic::AssertUnwindSafe<F> as core::ops::function::FnOnce<()>>::call_once::h2910e71977d69945 (0x5579f4a2da77)
 289: _ZN3std9panicking3try7do_call17h954357f2aec8b38cE.llvm.7282273553544605765 (0x5579f49edf46)
 290: __rust_maybe_catch_panic (0x5579f5e7a779)
             at src/libpanic_unwind/lib.rs:85
 291: <rayon_core::job::StackJob<L,F,R> as rayon_core::job::Job>::execute::h99e6d774fcb035ea (0x5579f4a75b94)
 292: rayon_core::registry::WorkerThread::wait_until_cold::h00f809e73c890927 (0x5579f58e9815)
 293: rayon_core::registry::main_loop::h3f4676bb8974f3ca (0x5579f58ea43b)
 294: _ZN3std9panicking3try7do_call17h38863160cb06b7a4E.llvm.1030418900502061180 (0x5579f58edffb)
 295: __rust_maybe_catch_panic (0x5579f5e7a779)
             at src/libpanic_unwind/lib.rs:85
 296: core::ops::function::FnOnce::call_once{{vtable.shim}}::ha2f24e28093369da (0x5579f58eb31f)
 297: call_once<(),FnOnce<()>> (0x5579f5e5dd1e)
             at /rustc/a9ec99f4201ec33026a468ef1289f98a95b4d71a/src/liballoc/boxed.rs:704
 298: call_once<(),alloc::boxed::Box<FnOnce<()>>> (0x5579f5e79a8f)
             at /rustc/a9ec99f4201ec33026a468ef1289f98a95b4d71a/src/liballoc/boxed.rs:704
      start_thread
             at src/libstd/sys_common/thread.rs:13
      thread_start
             at src/libstd/sys/unix/thread.rs:79
 299: start_thread (0x7f3a43077181)
 300: __clone (0x7f3a42c05b1e)

How to reproduce it (as minimally and precisely as possible): In my case it happens every time.

Environment:

  • Servo version:
Servo 0.0.1-97ad913dc
  • OS (e.g: cat /etc/os-release):
➜  servo cat /etc/os-release
NAME="Ubuntu"
VERSION="19.04 (Disco Dingo)"
ID=ubuntu
ID_LIKE=debian
PRETTY_NAME="Ubuntu 19.04"
VERSION_ID="19.04"
HOME_URL="https://www.ubuntu.com/"
SUPPORT_URL="https://help.ubuntu.com/"
BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/"
PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy"
VERSION_CODENAME=disco
UBUNTU_CODENAME=disco
  • Kernel:
➜  servo uname -a
Linux moonman-PC 5.0.0-16-generic #17-Ubuntu SMP Wed May 15 10:52:21 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

About this issue

  • Original URL
  • State: closed
  • Created 7 years ago
  • Comments: 15 (7 by maintainers)

Most upvoted comments

We’re a large project with a small team, so some amount if inactivity is expected, sadly. We prefer to keep issues open if they’re still relevant, even if they’re not being actively investigated.