rmm: [BUG] rmm v22.12 does not build from source

Describe the bug Latest stable version (v0.15) does not build from source as it is missing a dependency.

../include/rmm/mr/device/logging_resource_adaptor.hpp:22:10: fatal error: spdlog/sinks/basic_file_sink.h: No such file or directory
   22 | #include <spdlog/sinks/basic_file_sink.h>

SPDlog is not fetched hence causing build failure. It is also missing from listed/known dependencies: https://github.com/rapidsai/rmm/blob/v0.15.0/README.md#get-rmm-dependencies

Steps/Code to reproduce bug

git clone --recurse-submodules https://github.com/rapidsai/rmm.git -b v0.15.0 && cd rmm
bash build.sh

Expected behavior Build, fetch missing dependencies, install, all successfully

This PR https://github.com/rapidsai/rmm/pull/580 reference SPDLog as a dep but it should still be listed.

About this issue

  • Original URL
  • State: closed
  • Created 4 years ago
  • Comments: 16 (16 by maintainers)

Most upvoted comments

In the future, please open a new issue. Especially since this is a very different issue from the old one.

So yeah, even after #580 there’s still a problem in your case. I have a fix in progress, but I’ll do it as a separate PR (after #580) since it affects only the python side of things.